merge queue: checking main (8eb12d5) and #7213 together - #7238
Closed
mergify[bot] wants to merge 2 commits into
Closed
merge queue: checking main (8eb12d5) and #7213 together#7238mergify[bot] wants to merge 2 commits into
mergify[bot] wants to merge 2 commits into
Conversation
Browse.vue registers window 'online'/'offline' listeners but never removes them. Since only LibraryPage is kept alive by the router, Browse unmounts every time the user navigates away (e.g. into a project) and remounts on return, leaking a new pair of closures (and pinning the whole component scope) on window each time. Over a browsing session this accumulates continuously.
2 tasks
Contributor
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch main (8eb12d5) and #7213 are queued together for merge.
1 scope
This pull request has been created by Mergify to check the mergeability of #7213.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:github-review-approved[🛡 GitHub branch protection]check-success = Lint and Testcheck-neutral = Lint and Testcheck-skipped = Lint and TestRequired conditions to stay in the queue:
github-review-approved[🛡 GitHub branch protection]check-success = Lint and Testcheck-neutral = Lint and Testcheck-skipped = Lint and TestQueue graph
The diagram is not laid out in queue order, so a node's position says nothing about when it merges.
graph LR c3f7124eaf974b42b289dc9879ef92c5["institutional-laurier-njrk3p<br/>#7217<br/>scopes: backend"] 833fecc2f9a741218a8e02863c32cb89["stunning-framboise-kt9vfb<br/>#7213<br/>scopes: app"] style 833fecc2f9a741218a8e02863c32cb89 fill:#6366f1,color:#fff