Expose feeClaim on MdkNodeOptions - #46
Merged
Merged
Conversation
The ldk-node bump to f43d869 (0.1.87) added the fee_claim parameter to set_liquidity_source_lsps4 but pinned it to None. This threads it from a new optional MdkNodeOptions field instead, so a consumer can present a signed LSPS4 fee claim at registration. agent-wallet is the first consumer (MDK-1271, 0.5% grant); merchant checkout callers that omit the field are byte-for-byte unchanged on the wire. index.d.ts is regenerated by napi build; besides feeClaim it picks up two doc comments that had drifted since the last regen (startReceiving, getMaxSendable).
CI's clippy moved to 1.97, which now flags the outer match-Some-else-return-None in next_event (pre-existing code, first CI run since the toolchain moved). Mechanical: the suggested `?` transform plus the rustfmt arm collapse it enables; `git diff -w` is three hunks. No behavior change.
amackillop
added a commit
that referenced
this pull request
Jul 29, 2026
The dev shell and CI resolved toolchains from independent clocks: fenix "stable" moves on nix flake update (was 1.95), while dtolnay/rust-toolchain@stable moves on every Rust release (1.97). The gap meant CI could lint code the dev shell's clippy had never seen, which is exactly how PR #46 went red on untouched code. rust-toolchain.toml is now the single pin: the flake builds the dev shell from it (fenix fromToolchainFile) and CI installs from it via plain rustup, so neither side can move alone. Bumping the channel means updating the toml plus the sha256 next to it (build once with lib.fakeSha256 to learn the new one), and possibly the fenix input. Also disables nix's fortify hardening in the shell: combined with cargo's -O0 it makes glibc emit a #warning that jemalloc's -Werror configure probes turn into "cannot determine return type of strerror_r", so cargo check never got off the ground in the shell. just ci now passes in the dev shell under the same clippy CI runs. The napi release matrix keeps its own RUST_VERSION pin (1.85) in CI.yml; prebuilt binaries are a separate decision from lint parity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ldk-node bump to f43d869 (0.1.87) added the fee_claim parameter to set_liquidity_source_lsps4 but pinned it to None. This threads it from a new optional MdkNodeOptions field instead, so a consumer can present a signed LSPS4 fee claim at registration. agent-wallet is the first consumer (MDK-1271, 0.5% grant); merchant checkout callers that omit the field are byte-for-byte unchanged on the wire.
index.d.ts is regenerated by napi build; besides feeClaim it picks up two doc comments that had drifted since the last regen (startReceiving, getMaxSendable).