RUBY-3946 - Check connection back in when a load-balanced initial command fails - #3104
Open
drymar wants to merge 2 commits into
Open
RUBY-3946 - Check connection back in when a load-balanced initial command fails#3104drymar wants to merge 2 commits into
drymar wants to merge 2 commits into
Conversation
smoke
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.mongodb.org/browse/RUBY-3946
In load-balanced topology, cursor-returning operations check a connection out of the pool before executing the initial command so the cursor can retain it. When that command fails, no cursor exists to drain and check the connection back in, so the pool permanently loses a slot on every failure; a process accumulating such failures eventually cannot check out any connection (ConnectionCheckOutTimeout with the full pool checked out and nothing pending) and never recovers.
ChangeStream and Database#cursor_command already release the connection on failure (the former since #3041). This applies the same handling to the remaining initial-command sites:
Connections pinned to a transaction are left checked out, matching Database#cursor_command.
Reproduction: