Skip to content

Don't retry arc diff when it stops to ask a question, and say which. - #466

Closed
tomrittervg wants to merge 1 commit into
masterfrom
2026-11-13-tjr-arc-prompts
Closed

tomrittervg wants to merge 1 commit into
masterfrom
2026-11-13-tjr-arc-prompts

Conversation

@tomrittervg

Copy link
Copy Markdown
Collaborator

arc diff exits when it needs an answer, because stdin isn't a TTY, and it asks the same question every time. PDF.js's update to 7a4022e2 (bug 2092381) changed binary cmap files that arc doesn't recognise as binary, so arc asked whether to mark them as binary; we retried it four times over nine minutes, then commented only that we couldn't submit to Phabricator. Give up on the first attempt, and quote the question in the comment.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The stdout-only mock leaves the terminal-failure classification unverified because real arc output has not confirmed the prompt’s stream placement or trailing [Y/n] or [y/N] markers.

No open issues 🎉

What changed in this PR

This PR updates automated Phabricator submissions to stop retrying when arc diff asks an interactive question and include that question in the Bugzilla failure comment.

Changes:

  • Detect unanswered yes/no prompts and raise an error that bypasses retries.
  • Include the extracted question in the existing submission-failure notification.
  • Add a regression test covering a single attempt, the terminal job outcome, and the reported question.
File Description
tests/​functionality_all_platforms.py Tests prompt handling, retry suppression, and Bugzilla reporting.
tasktypes/​vendoring.py Includes prompt details in submission-failure comments.
apis/​phabricator.py Detects unanswered prompts and stops retries with a dedicated exception.

Review effort: Balanced

arc diff exits when it needs an answer, because stdin isn't a TTY, and it
asks the same question every time. PDF.js's update to 7a4022e2 (bug
2092381) changed binary cmap files that arc doesn't recognise as binary,
so arc asked whether to mark them as binary; we retried it four times
over nine minutes, then commented only that we couldn't submit to
Phabricator. Give up on the first attempt, and quote the question in the
comment.
@tomrittervg
tomrittervg force-pushed the 2026-11-13-tjr-arc-prompts branch from 9615ccc to adde21a Compare November 13, 2026 14:42
@tomrittervg
tomrittervg deleted the 2026-11-13-tjr-arc-prompts branch November 14, 2026 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants