Repository navigation
Don't retry arc diff when it stops to ask a question, and say which. - #466
Closed
tomrittervg wants to merge 1 commit into
Closed
tomrittervg wants to merge 1 commit into
tomrittervg wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The stdout-only mock leaves the terminal-failure classification unverified because real arc output has not confirmed the prompt’s stream placement or trailing [Y/n] or [y/N] markers.
No open issues 🎉
What changed in this PR
This PR updates automated Phabricator submissions to stop retrying when arc diff asks an interactive question and include that question in the Bugzilla failure comment.
Changes:
- Detect unanswered yes/no prompts and raise an error that bypasses retries.
- Include the extracted question in the existing submission-failure notification.
- Add a regression test covering a single attempt, the terminal job outcome, and the reported question.
| File | Description |
|---|---|
tests/functionality_all_platforms.py |
Tests prompt handling, retry suppression, and Bugzilla reporting. |
tasktypes/vendoring.py |
Includes prompt details in submission-failure comments. |
apis/phabricator.py |
Detects unanswered prompts and stops retries with a dedicated exception. |
Review effort: Balanced
arc diff exits when it needs an answer, because stdin isn't a TTY, and it asks the same question every time. PDF.js's update to 7a4022e2 (bug 2092381) changed binary cmap files that arc doesn't recognise as binary, so arc asked whether to mark them as binary; we retried it four times over nine minutes, then commented only that we couldn't submit to Phabricator. Give up on the first attempt, and quote the question in the comment.
tomrittervg
force-pushed
the
2026-11-13-tjr-arc-prompts
branch
from
November 13, 2026 14:42
9615ccc to
adde21a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
arc diff exits when it needs an answer, because stdin isn't a TTY, and it asks the same question every time. PDF.js's update to 7a4022e2 (bug 2092381) changed binary cmap files that arc doesn't recognise as binary, so arc asked whether to mark them as binary; we retried it four times over nine minutes, then commented only that we couldn't submit to Phabricator. Give up on the first attempt, and quote the question in the comment.