Repository navigation
Bug 2083532 - Webhook bug.modify payload has empty bug.flags when flags are set at bug creation - #2791
Merged
Conversation
…gs are set at bug creation
There was a problem hiding this comment.
🟢 Approval recommended
The targeted cache invalidation addresses the stale payload, with regression coverage and no unresolved findings.
No open issues 🎉
What changed in this PR
Fixes stale Push webhook payloads so bug.modify includes flags set during bug creation.
Changes:
- Clears cached deep and shallow serialization before pushing an object.
- Adds a regression test covering flags set during creation.
| File | Description |
|---|---|
| extensions/Push/t/bmo/bug_create_flags.t | Tests flag contents in create and modify payloads. |
| extensions/Push/lib/Serialize.pm | Adds object-specific cache invalidation. |
| extensions/Push/Extension.pm | Invalidates cached serialization before each push. |
Review effort: Balanced
cgsheeh
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.