Repository navigation
Hold pinches until Loop accepts them - #1185
Draft
jvanderen1 wants to merge 2 commits into
Draft
jvanderen1 wants to merge 2 commits into
jvanderen1 wants to merge 2 commits into
Conversation
…een ring. A bound pinch or spread keeps Show Desktop from starting. Maximize is chosen once the pinch is recognizable, and pinching back inside that ring cancels it. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Builds on the scroll hold in #1176. A bound pinch or spread now holds the zoom events the same way, including both Show Desktop and Launchpad, because the first sample can point the wrong way. Maximize is selected once the pinch is recognizable, instead of waiting for a larger step that made a visible gesture do nothing on lift. Pinching back inside that first ring cancels it.
How has this been tested?
Screenshots (if appropriate)
Checklist:
Please describe to which degree, if any, an LLM was used in creating this pull request.
An LLM drafted the implementation and the stress-test notes in
docs/trackpad-gesture-stress-test.md. The behavior was then exercised locally on macOS.Made with Cursor