Skip to content

Consume cached nil in Unpacker#skip_nil #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
byroot merged 1 commit into from
Aug 30, 2026
Merged

Consume cached nil in Unpacker#skip_nil #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/msgpack/unpacker.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -911,8 +911,8 @@ int msgpack_unpacker_skip_nil(msgpack_unpacker_t* uk)
return b;
}
if(b == 0xc0) {
reset_head_byte(uk);
return 1;
}
return 0;
}

3 changes: 2 additions & 1 deletion spec/cruby/unpacker_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@
end

it 'skip_nil succeeds' do
unpacker.feed("\xc0")
unpacker.feed("\xc0*")
unpacker.skip_nil.should == true
unpacker.unpack.should == 42
end

it 'skip_nil fails' do
Expand Down
Loading