Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A source refresh could finish fetching after DELETE returned and put the removed file and vectors back. Re-registering the same collection could also schedule duplicate refreshes.
Make collection registration idempotent and check that a refresh still belongs to the same source before storing. A collection lock orders refresh writes and removals without blocking source operations in other collections.
Closes #32.
Validation:
go test -race -count=1 ./rag ./rag/engine -run 'TestSource|TestMemoryChromem'andgo vet ./rag ./rag/engine .passed.go test -count=1 ./...reports the same failures on the clean base and this change: unavailable LocalAI/PostgreSQL services and pre-existing function-signature errors intest/raw. No real model was used, and this change does not coordinate source deletion across server replicas.