Skip to content

[test][button] Add axe test coverage and WCAG conformance report - #48916

Open
michelengelen wants to merge 3 commits into
mui:masterfrom
michelengelen:a11y/stack/button
Open

[test][button] Add axe test coverage and WCAG conformance report#48916
michelengelen wants to merge 3 commits into
mui:masterfrom
michelengelen:a11y/stack/button

Conversation

@michelengelen

@michelengelen michelengelen commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Expands axe coverage for Button and adds its WCAG 2.2 Level A/AA conformance report, plus the shared reports legend at packages/mui-material/src/accessibility.md.

Result Count
✅ Supports 23
⚠️ Partially Supports 4
❌ Does Not Support 0
➖ Not Applicable 28

Known gaps: contrast on info/warning contained buttons (1.4.3), focus-indicator contrast and its removal via disableRipple (1.4.11, 2.4.7), and no live region for the loading state (4.1.3).

Report: Button/accessibility.md

Important

How to review this PR

Layer 3 of 14 in a stacked series (#48915 → #48926). Its branch is built on a11y/stack/css-layout (#48936). GitHub cannot chain PR bases across a fork, so every PR in the series targets master instead.

Review only the last commit — 5c23780. Everything above it belongs to the layers below, and disappears as those merge.

Original work by @mj12albert. Supersedes #48708, rebased onto current master.

Part of the WCAG conformance effort (#14187).

This was referenced Aug 4, 2026
Open
Closed
@code-infra-dashboard

code-infra-dashboard Bot commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Deploy preview

Bundle size

Bundle Parsed size Gzip size
@mui/material 0B(0.00%) 0B(0.00%)
@mui/lab 0B(0.00%) 0B(0.00%)
@mui/private-theming 0B(0.00%) 0B(0.00%)
@mui/system 0B(0.00%) 0B(0.00%)
@mui/utils 0B(0.00%) 0B(0.00%)

Details of bundle changes

Check out the code infra dashboard for more information about this PR.

@michelengelen michelengelen added test accessibility a11y scope: button Changes related to the button. labels Aug 5, 2026
@michelengelen
michelengelen force-pushed the a11y/stack/button branch 5 times, most recently from 212555a to 9b9147b Compare August 6, 2026 10:43
@michelengelen
michelengelen marked this pull request as ready for review August 7, 2026 10:15
@michelengelen
michelengelen force-pushed the a11y/stack/button branch 2 times, most recently from 764f1ed to d60b37a Compare August 7, 2026 13:00
@mj12albert @michelengelen
[test] Add an assertions mode to the axe regression harness
a0b8a93 
Lets a fixture assert every axe rule it exercises rather than only the
CSS-dependent visual ones, which is what the per-component WCAG reports
need.
@mj12albert @michelengelen
[test] Automate the CSS-dependent WCAG criteria
8e3e84e 
Adds a table-driven Playwright suite covering 1.4.10 Reflow, 1.4.4 Resize
Text and 1.4.12 Text Spacing across the assessed components. axe has no rule
for any of them, so they were rated Manual on evidence from source review.
@mj12albert @michelengelen
[test][button] Add axe test coverage and WCAG conformance report
5c23780
@michelengelen

michelengelen commented Aug 18, 2026

Copy link
Copy Markdown
Member Author

PR review

No findings.

This PR sets the template for the stack and it is internally consistent. Checked: the demoMeta enrolment matches the 15 keys in buttons.a11y.json; the only recorded non-pass is the deliberate color-contrast fail on ButtonA11yColorMatrix, whose rule skips exactly that assertion; the screenshot opt-out/opt-in pair for the ButtonA11y* fixtures is ordered correctly for last-match-wins; nativeButton exists on ButtonBase, so the ButtonA11yNonNative demo is valid; the count table (23 + 4 + 28 = 55 criteria, 8/27 flagged) matches the WCAG 2.2 A/AA total and the later rollup.

Residual risk: the 371-line conformance report was spot-checked against the code, not verified claim by claim, and the new demos are regression-harness-only (not referenced from buttons.md), which is deliberate per the in-code comments.

Verdict

Approve - the enrolment, fixtures, tests, and report counts are consistent end to end.

🤖 Review generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@silviuaavram silviuaavram Awaiting requested review from silviuaavram
@siriwatknp siriwatknp Awaiting requested review from siriwatknp

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

accessibility a11y scope: button Changes related to the button. test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michelengelen @mj12albert