Skip to content

[test][checkbox] Add axe tests and WCAG conformance report - #48918

Open
michelengelen wants to merge 5 commits into
mui:masterfrom
michelengelen:a11y/stack/checkbox
Open

[test][checkbox] Add axe tests and WCAG conformance report#48918
michelengelen wants to merge 5 commits into
mui:masterfrom
michelengelen:a11y/stack/checkbox

Conversation

@michelengelen

@michelengelen michelengelen commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Adds axe coverage and the WCAG 2.2 Level A/AA conformance report for Checkbox.

Result Count
✅ Supports 22
⚠️ Partially Supports 3
❌ Does Not Support 0
➖ Not Applicable 30

Known gaps: focus-indicator contrast and custom icons below 3:1 (1.4.11), disableRipple removing the focus indicator (2.4.7), and indeterminate setting aria-checked="mixed" on a native checkbox whose checked is false (4.1.2) — the one genuine defect in the series.

Report: Checkbox/accessibility.md

Important

How to review this PR

Layer 5 of 14 in a stacked series (#48915 → #48926). Its branch is built on a11y/stack/avatar (#48917). GitHub cannot chain PR bases across a fork, so every PR in the series targets master instead.

Review only the last commit — 2ee61e1. Everything above it belongs to the layers below, and disappears as those merge.

Original work by @mj12albert. Supersedes #48734, rebased onto current master.

Part of the WCAG conformance effort (#14187).

This was referenced Aug 4, 2026
Open
Closed
@code-infra-dashboard

code-infra-dashboard Bot commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Deploy preview

Bundle size

Bundle Parsed size Gzip size
@mui/material 0B(0.00%) 0B(0.00%)
@mui/lab 0B(0.00%) 0B(0.00%)
@mui/private-theming 0B(0.00%) 0B(0.00%)
@mui/system 0B(0.00%) 0B(0.00%)
@mui/utils 0B(0.00%) 0B(0.00%)

Details of bundle changes

Check out the code infra dashboard for more information about this PR.

@michelengelen michelengelen added test accessibility a11y scope: checkbox Changes related to the checkbox. labels Aug 5, 2026
@michelengelen
michelengelen force-pushed the a11y/stack/checkbox branch 5 times, most recently from cab0815 to 8ba1e37 Compare August 6, 2026 10:43
@michelengelen
michelengelen marked this pull request as ready for review August 7, 2026 10:15
@michelengelen
michelengelen force-pushed the a11y/stack/checkbox branch 2 times, most recently from 178bc94 to cb67f12 Compare August 7, 2026 13:00
@mj12albert @michelengelen
[test] Add an assertions mode to the axe regression harness
a0b8a93 
Lets a fixture assert every axe rule it exercises rather than only the
CSS-dependent visual ones, which is what the per-component WCAG reports
need.
@mj12albert @michelengelen
[test] Automate the CSS-dependent WCAG criteria
8e3e84e 
Adds a table-driven Playwright suite covering 1.4.10 Reflow, 1.4.4 Resize
Text and 1.4.12 Text Spacing across the assessed components. axe has no rule
for any of them, so they were rated Manual on evidence from source review.
@mj12albert @michelengelen
[test][button] Add axe test coverage and WCAG conformance report
5c23780
@mj12albert @michelengelen
[test][avatar] Add axe tests and WCAG conformance report
1482433
@mj12albert @michelengelen
[test][checkbox] Add axe tests and WCAG conformance report
2ee61e1
@michelengelen

michelengelen commented Aug 18, 2026

Copy link
Copy Markdown
Member Author

PR review

Clean PR. The IndeterminateCheckbox skip is the right call — the aria-conditional-attr hit is a real, documented gap of the component, and the rule records it in the JSON instead of hiding it. One weak test title.

Tests (1)

1. 🟡 Test title claims more than it asserts

Location: packages/mui-material/src/Checkbox/Checkbox.test.js:424

it('reflects the checked state and notifies on change', async () => {

The test asserts only the checked flip after user.click. No change handler is asserted, so the "notifies on change" half of the name is untested here (it is covered by the 2.1.1 test, but under a different claim).

Failure scenario: an onChange regression passes this test while its name says the notification is verified.

Fix: assert a spy's call count, or rename the test to "reflects the checked state".

Verdict

Approve after nits - solid coverage; one test name to align with its assertions.

🤖 Review generated with Claude Code

@michelengelen michelengelen mentioned this pull request Aug 18, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@silviuaavram silviuaavram Awaiting requested review from silviuaavram
@siriwatknp siriwatknp Awaiting requested review from siriwatknp

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

accessibility a11y scope: checkbox Changes related to the checkbox. test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michelengelen @mj12albert