Repository navigation
Replace MT19937 with NumPy PCG64 - #98
Open
MLopez-Ibanez wants to merge 2 commits into
Open
MLopez-Ibanez wants to merge 2 commits into
MLopez-Ibanez wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
==========================================
+ Coverage 78.44% 78.47% +0.03%
==========================================
Files 70 69 -1
Lines 7593 7585 -8
Branches 1477 1475 -2
==========================================
- Hits 5956 5952 -4
+ Misses 1267 1262 -5
- Partials 370 371 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
MLopez-Ibanez
force-pushed
the
copilot/pcg64-rng
branch
from
November 12, 2026 14:29
652d9cc to
bd12cfa
Compare
Source: numpy/numpy@98acfbd, numpy/random/src/pcg64 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Silence conversion warnings with explicit casts, including the emulated 128-bit paths used on Windows. Use the inline PCG64 routines directly and retain upstream provenance. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
MLopez-Ibanez
force-pushed
the
copilot/pcg64-rng
branch
from
November 12, 2026 18:09
bd12cfa to
c2b3aa3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pcg64.handLICENSE.mdin the first commit, pinned to98acfbde9876839be145d022beb76e7ff835e8e1.pcg64.cor a standalone C RNG test.Merge the compatible external regressions in multi-objective/testsuite#7 first.
Fixes #85
Validation
make testwith-O3 -fltoandWERROR=1: all 111 external regressions pass; C distribution inputs verified.R CMD check --no-manual --no-vignettescompletes without errors or warnings (3 notes).make time,make test,make asan,make ubsan) passed. The hosted external matrix passed on that earlier PR revision.On 32-bit MinGW, upstream tests of
_M_AMD64emit-Wundefwarnings when that flag is enabled; those upstream conditionals are unchanged to keep the vendor delta limited to casts.