Skip to content

refactor(manualaccountmenu): changing manual account menu to use MUI … - #373

Merged
wesrisenmay-mx merged 6 commits into
masterfrom
wes/CT-2473/manualAccountMenu
Aug 28, 2026
Merged

refactor(manualaccountmenu): changing manual account menu to use MUI …#373
wesrisenmay-mx merged 6 commits into
masterfrom
wes/CT-2473/manualAccountMenu

Conversation

@wesrisenmay-mx

Copy link
Copy Markdown
Collaborator

…list instead of kyper

@wesrisenmay-mx

wesrisenmay-mx commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator Author

Before: (This is on sand which has an old widget version, so the changes include other changes that have been made)
image

After:

image

@wesrisenmay-mx
wesrisenmay-mx marked this pull request as ready for review August 25, 2026 16:44
@mwclemy

mwclemy commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Is design fine with not having a divider between account types anymore? Also, the icon color now looking greyish?

ash-wright123
ash-wright123 previously approved these changes Aug 25, 2026

@ash-wright123 ash-wright123 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however I think we will need a ticket to remove the overrides when we move to mxui v2

Comment thread src/ConnectedTokenProvider.tsx Outdated
@ash-wright123
ash-wright123 self-requested a review August 25, 2026 19:33
@wesrisenmay-mx

Copy link
Copy Markdown
Collaborator Author

Is design fine with not having a divider between account types anymore? Also, the icon color now looking greyish?

Yes I worked with design to get where we are, and confirmed with Jen with the screenshot

Comment thread src/views/manualAccount/ManualAccountMenu.tsx Outdated
Comment thread src/ConnectedTokenProvider.tsx Outdated
Comment thread src/shared/MuiList/FlushListContainer.tsx Outdated
Comment thread src/shared/theme/theme.ts Outdated
Comment thread src/ConnectedTokenProvider.tsx Outdated

@mwclemy mwclemy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@wesrisenmay-mx
wesrisenmay-mx merged commit 9b7daf7 into master Aug 28, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants