feat: migrating all @kyper/messagebox usages to MUI Alert - #374
Open
Jameson13B wants to merge 4 commits into
Open
feat: migrating all @kyper/messagebox usages to MUI Alert#374Jameson13B wants to merge 4 commits into
Jameson13B wants to merge 4 commits into
Conversation
Jameson13B
requested review from
ash-wright123,
codingLogan,
mwclemy and
wesrisenmay-mx
as code owners
August 24, 2026 18:15
| style={styles.messageBox} | ||
| variant="error" | ||
| severity="error" | ||
| sx={styles.messageBox} |
Collaborator
There was a problem hiding this comment.
According to the ADR we should be using CSS style sheets and class names.
| // Determines if we should show the message box at the top of the credentials view | ||
| export const shouldShowMessageBox = (error, currentMember, mode = AGG_MODE) => { | ||
| // Determines if we should show the alert at the top of the credentials view | ||
| export const shouldShowAlert = (error, currentMember, mode = AGG_MODE) => { |
Collaborator
There was a problem hiding this comment.
Looks like this function is missing unit tests, because changing the name didn't break anything.
Collaborator
|
Can we get screenshots for all the different places? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Jira Link: https://mxcom.atlassian.net/browse/246
Migrating all
@kyper/messageboxusages to MUIAlertComponents Changed:
DeleteMemberSurveryMemberErrorCredentialsLoginErrorStatusAlertmanualAccountFormMFAStepMicrodepositErrorsVerifyDepositsOAuthErrorVerifyErrorTest Evidence
Click to expand testing evidence
Example Screenshots