Repository navigation
docs: record mutation-harness and heading-assertion pitfalls - #6
Merged
Merged
Conversation
Three lessons measured while adding the third gate, each of which produced a
wrong conclusion before it was caught:
1. A mutation harness must verify it actually changed bytes on disk. Three
mutations were reported as "not caught" when the script had silently failed
to write; the assertions were sound. A harness that cannot prove it mutated
is evidence of nothing.
2. `assertIn("Gate name", rubric)` cannot detect a deleted heading when the same
string also appears in a link on the next line. Pin the heading form
(`## Gate name`) so the assertion fails when the section is removed.
3. A class-level detector test passes while any one of its patterns fires, so a
single deleted regex leaves the suite green. Pin the pattern inventory by
identity; the inventory is the contract.
Also bumps SKILL.md to 3.5.1.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three lessons measured while adding the third gate, each of which produced a wrong conclusion before it was caught:
assertIn("Gate name", rubric)cannot detect a deleted heading when the same string also appears in a link on the next line. Pin the heading form (## Gate name) so the assertion fails when the section is removed.Also bumps SKILL.md to 3.5.1.