Repository navigation
feat: block venue-ambition leakage in publication-facing prose - #9
Merged
Merged
Conversation
The publication target is a decision made between the author and their collaborators, not a property of the work. A manuscript that argues its own venue tier, states an intent to submit, or anticipates a referee reaction has imported the planning conversation into the artifact, and no reader of the published paper can act on any of it. This is a strategy leak rather than a wording defect, so the class is licensed by genre instead of by phrasing: the same sentence is correct in a cover letter and blocking in a manuscript. Both directions are pinned by test, because a gate that only ever fires proves nothing about its licensing. Calibration mattered more than detection here. The first pattern set produced six false positives on correct prose -- interquartile ranges, fiscal quarters, Scopus named as a search source in Methods, and the substring `venue` inside `Revenue`. Co-occurrence with a venue/submission term plus word boundaries removed all six with no loss of recall; the cases are kept as permanent tests. Verified by mutation: removing the code from the blocking set, unlicensing the cover-letter genre, deleting the Vietnamese referee pattern, deleting the rubric bullet, and restoring the Revenue false positive each turn the suite red, and each is restored green afterwards.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
venue_ambition_leakas a blocking class in the internal-register gate. The publication target -- venue tier, impact metric, intent to submit, or an anticipated referee reaction -- is a planning decision between the author and their collaborators. Inside publication-facing prose it is unusable: a reader of the published paper cannot act on any of it.Licensed by genre, not by wording
The same sentence is correct in a cover letter and blocking in a manuscript, so the class is licensed through
GENRE_LICENSED(cover_letter,revision_notes) rather than through phrasing. Both directions are pinned by test: a gate that only ever fires proves nothing about its licensing.Calibration was the hard part
The first pattern set produced six false positives on correct academic prose:
interquartile rangequartilethe first quartile falls at 0.79quartileRevenue in Q1 of the observation windowvenueinsideRe**venue**, andQ1as a fiscal quarterretrieved from Scopus and Web of Sciencethe impact of annotator disagreementimpactFixed by requiring co-occurrence with a venue/submission term and by adding word boundaries. All six are kept as permanent tests so the same false positive cannot return at the next pattern edit.
Verification
Four mutations, each restored green afterwards:
BLOCKING-> caught by validatorRevenuefalse positive -> caught by validatorThe rubric mutation initially passed:
assertIn("venue_ambition_leak", rubric)stayed green because the code also appears in the explanatory paragraph below the list. The assertion now pins the bullet form for all 23 codes. That pitfall, and theRevenuesubstring lesson, are recorded inreferences/skill-repository-maintenance.md.Suite