Repository navigation
feat(storefront): the copy button says "Copied" to screen readers too - #61
Merged
Merged
Conversation
A storefront page's code block has no copy button in its markup any more.
The page's script adds one only where the browser can copy, so without
scripting or a clipboard there is no button a skin's CSS could show. The
outcome ("Copied", "Not copied") is also said in a polite live region,
since the button's name doesn't change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first item of 0.5.0, from the 0.4.2 findings.
The workbench's own copy buttons are unchanged. Test: storefront-bench
e2e/copy.spec.ts(dev and static): the live region says "Copied"; without a clipboard there is no button even with a stylesheet that forces.copy-btnvisible; with JavaScript off the markup has no button. Each case failed on 0.4.2.All gates pass locally on Node 22.22 and 24.22 (dev-ui E2E 354, storefront 179, skin 155, package-bench 7).