Repository navigation
0.5.0 step 7: the small items - #70
Merged
Merged
Conversation
…bench LayoutPageUse gains the source "generated" for a tag or category page and the index of them, naming what generated it (kind and term). A layout's Relationships tab lists them after the page files, by route. The detail route now reads the page model with the discovery map, so the term pages are in it.
A spec that no project's testMatch takes never runs, and its suite stays green without it. The script tests now list each Playwright config's files and fail naming any tracked spec none of its projects matches.
The site for language models, in the llmstxt.org format: the site's title and the home page's description, then the top-level pages and one section per collection, each page with its title, link and teaser. The same pages as the sitemap (no drafts, scheduled pages or index: false), absolute URLs with storefront.url, under the site's path. On unless the site has index: false; storefront.llms: false turns it off.
Each class on a site page that no stylesheet of the style guide names and no component template writes is listed, naming the page's file and line. A word a template builds from a value defines its family; state classes, Pattern Dump's own tooling classes and storefront.checks.allowClasses are allowed. A warning by default; storefront.checks.classes "error" stops the build, "off" skips it. The starter's install check asserts its pages are clean.
A var(--x) without a fallback in the project's own styles, with no --x in any compiled stylesheet of the style guide or its packages, a stylesheet the site loads, or a style attribute the build writes, stops the build, naming file and line. Properties JavaScript sets go in storefront.checks.allowProperties. The CSS reading is shared with the class check.
storefront-build.spec.ts took about 190 s a run on a loaded runner, so its 20 burn-in repeats alone came to more than the job's 60 minutes, and the burn-in groups split by file, never within one. Its settings tests move, unchanged, into three files: storefront-build-settings.spec.ts (workbench URL, storefront.url, sitemap, robots.txt, the 404 page and the output folders), storefront-build-same-host.spec.ts (a workbench on the storefront's host and its base path) and storefront-llms.spec.ts. The same 34 tests run.
Measured from the six burn-in jobs of run 43846557396. The four storefront build spec files split from storefront-build.spec.ts share its measured time by the sums of their tests in that run, until a later refresh measures them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five small items for 0.5.0, one commit each.
LayoutPageUsegains the source"generated"(a tag or category page, or the index of them), naming its kind and term. A layout's Relationships tab lists them after the page files. The detail route now reads the page model with the discovery map, so the term pages are in it.scripts/e2e-specs.test.mjs(intest:scripts) asks Playwright which files each config's projects take and fails naming any tracked spec none takes.pd buildwrites the site in the llmstxt.org format: title and description, the top-level pages and one section per collection, each page's title, link and teaser. Same pages as the sitemap, under the site's path. On unlessindex: false;storefront.llms: falseturns it off. Build only, no new route.storefront.checks.classes: "error" | "off",allowClasses.var(--x)without a fallback in the project's styles, with no definition in the style guide, its packages, a loaded stylesheet or a style attribute, stops the build, naming file and line.allowPropertiesfor what JavaScript sets.Docs: storefront.md, configuration.md, CHANGELOG. The starter's install check asserts its pages carry no class outside the style guide and that it writes llms.txt.