Repository navigation
Conversation
yyuu
marked this pull request as ready for review
October 30, 2026 07:48
…tore-by-default # Conflicts: # CHANGELOG.md
yyuu
marked this pull request as draft
November 2, 2026 01:56
yyuu
marked this pull request as ready for review
November 2, 2026 03:33
…#480) Until HTTPClient 3.0.0, MRI keeps using the bundled CA certificates by default. Loading them emits a deprecation notice once per process that points to OpenSSL::X509::DEFAULT_CERT_FILE as an opt-in replacement. - Add SSLConfig#cacert_file= to select a CA file. Assigning it replaces the certificate store and resets sessions. If loading fails, the previous file and store are kept. - Keep JRuby's runtime trust store as the default. An explicit load_trust_ca still adds the selected file, including the bundled one. - Cover the notice, file selection, and store replacement with tests. - Mark the 3.0.0 default change with TODO(3.0.0) comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenSSL::X509::DEFAULT_CERT_FILEstarting with HTTPClient 3.0.0 and shows how to opt in.SSLConfig#cacert_file=to select a CA file. Assigning it replaces the store and resets sessions. If loading fails, the previous configuration is kept.load_trust_castill works there.TODO(3.0.0)comments.Notes for reviewers
test/test_ssl.rbcontainsENV.delete('NIX_SSL_CERT_FILE')as a workaround for local Nix environments. It does not affect CI and is kept for now.Related to #480.