Repository navigation
Don't add a trailing '&' when the query argument is empty - #492
Open
AmeenKhan12345 wants to merge 1 commit into
Open
AmeenKhan12345 wants to merge 1 commit into
AmeenKhan12345 wants to merge 1 commit into
Conversation
When the URI already has a query and the query argument is empty
({}, [] or ''), create_query_part still appended "&", so
get("http://example.com/?a=1", {}) requested /?a=1&. Some servers
reject the resulting empty parameter.
Only append the query argument when it is not empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #491
Problem
When the URL already has a query and the
queryargument is empty ({},[]or''), HTTPClient adds a&with nothing after it:Some servers reject the empty parameter this creates. See the issue for a real case and a reproduction.
Change
In
create_query_part, the query argument is only appended (with&) when it isn't empty. Nothing else changes:?a=1+{ "b" => "2" }→?a=1&b=2.Tests
test_get_query_with_query_in_uri. It checks the request line fornil,{},[],''and{ "b" => "2" }on a URL that already has a query. The{},[]and''cases fail without the fix.--enable-frozen-string-literal --debug-frozen-string-literal.