Skip to content

test: accept OpenSSL 3.0 TLSv1 rejection alert - #493

Merged
yyuu merged 1 commit into
nahi:masterfrom
yyuu:ci/tlsv1-alert-compatibility
Nov 17, 2026
Merged

yyuu merged 1 commit into
nahi:masterfrom
yyuu:ci/tlsv1-alert-compatibility

Conversation

@yyuu

@yyuu yyuu commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Accept internal error as well as protocol version in TestSSL#test_disallow_tlsv1. Test-only change.

Context

The TLSv1 rejection alert varies by OpenSSL version. OpenSSL 3.0.12 rejects TLSv1 with internal_error instead of protocol version. This change accepts both. The test still requires an SSLError.

Testing

  • Full suite passes locally on MRI 2.5–4.0 and JRuby 10.1.
  • CI run: all 12 jobs passed on attempt 2. Attempt 1's Ruby 2.7 job hit an unrelated ReceiveTimeoutError in test_get_content_with_base_url. Re-running that job passed.

@yyuu
yyuu marked this pull request as ready for review November 17, 2026 01:49
@yyuu
yyuu merged commit 9515218 into nahi:master Nov 17, 2026
12 checks passed
@yyuu
yyuu deleted the ci/tlsv1-alert-compatibility branch November 17, 2026 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant