Repository navigation
Port the release QA fixes from MyTurnTagCreator-Android #139 - #86
Merged
Merged
Conversation
After a failed load (e.g. offline, "[NATIVEAPPTEMPLATE-2002] ..."), Reload succeeded but the error snackbar stayed until dismissed: the view model kept the message, so the screen's SnackbarMessageEffect kept showing it. Each screen's load and each sign-in attempt now clears the message when it starts, which cancels the shown snackbar; an error of the new attempt still shows. Ported from MyTurnTagCreator-Android #139. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YDK5huvuRECyVrsQEdTN9q
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the fixes from MyTurnTagCreator-Android #139 (2.1.0 release QA) that apply to this template.
Ported
[NATIVEAPPTEMPLATE-2002]), Reload succeeded but the error snackbar stayed until dismissed. Every screen's load (fetchData) and every sign-in attempt now clears the message when it starts, which closes the shown snackbar; an error of the new attempt still shows. Tests:ShopListViewModelTest(reload after a failed load clears the error; a failing reload shows its error),SignInEmailAndPasswordViewModelTest(same for sign-in), newSnackbarMessageEffectTest(clearing the message closes the Indefinite snackbar; the same error shows again). Test doubles:CallFailures.succeed,TestLoginRepository.failLogin(null).Checked, not applicable
ItemTagDetailViewalready reloads on resume (LifecycleEventEffect(ON_RESUME)).left in shop slots.has no spacing problem.Checks
SnackbarMessageEffectmade non-cancellable), and with a wrong fix that clears the message when the load ends instead of when it starts.spotlessCheck,:app:lintDebug,:app:minifyReleaseWithR8,test(414 tests) pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01YDK5huvuRECyVrsQEdTN9q