Skip to content

Port the release QA fixes from MyTurnTagCreator-Android #139 - #86

Merged
dadachi merged 1 commit into
mainfrom
fix/release-qa-ports
Oct 15, 2026
Merged

dadachi merged 1 commit into
mainfrom
fix/release-qa-ports

Conversation

@dadachi

@dadachi dadachi commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Ports the fixes from MyTurnTagCreator-Android #139 (2.1.0 release QA) that apply to this template.

Ported

  • Stale error snackbar: after a failed load (e.g. offline, [NATIVEAPPTEMPLATE-2002]), Reload succeeded but the error snackbar stayed until dismissed. Every screen's load (fetchData) and every sign-in attempt now clears the message when it starts, which closes the shown snackbar; an error of the new attempt still shows. Tests: ShopListViewModelTest (reload after a failed load clears the error; a failing reload shows its error), SignInEmailAndPasswordViewModelTest (same for sign-in), new SnackbarMessageEffectTest (clearing the message closes the Indefinite snackbar; the same error shows again). Test doubles: CallFailures.succeed, TestLoginRepository.failLogin(null).

Checked, not applicable

  • Item tag detail showing stale data after Edit: ItemTagDetailView already reloads on resume (LifecycleEventEffect(ON_RESUME)).
  • Shop slots footer vs the free plan: no billing here; the string left in shop slots. has no spacing problem.
  • Tab labels wrapping: two tabs (Shops, Settings); measured at 411 dp (Robolectric native graphics, en and ja), every label is one line. The same measurement does catch MyTurnTag's five-tab "Organisations" wrapping (2 lines).
  • Add button content description: the item tag list FAB already says "Add Item Tag".
  • Full-width yen in the per-month price: no billing here.

Checks

  • Each new test seen failing: with the fix reverted (and SnackbarMessageEffect made non-cancellable), and with a wrong fix that clears the message when the load ends instead of when it starts.
  • Local: spotlessCheck, :app:lintDebug, :app:minifyReleaseWithR8, test (414 tests) pass.

🤖 Generated with Claude Code

https://claude.ai/code/session_01YDK5huvuRECyVrsQEdTN9q

After a failed load (e.g. offline, "[NATIVEAPPTEMPLATE-2002] ..."),
Reload succeeded but the error snackbar stayed until dismissed: the view
model kept the message, so the screen's SnackbarMessageEffect kept
showing it. Each screen's load and each sign-in attempt now clears the
message when it starts, which cancels the shown snackbar; an error of
the new attempt still shows.

Ported from MyTurnTagCreator-Android #139.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YDK5huvuRECyVrsQEdTN9q
@dadachi
dadachi merged commit f9e33d7 into main Oct 15, 2026
1 check passed
@dadachi
dadachi deleted the fix/release-qa-ports branch October 15, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant