Repository navigation
Let the last row of FAB lists scroll above the button - #88
Merged
Merged
Conversation
The last row of Manage Item Tags (and the Delete button its swipe reveals) stayed under the + button, because the list had no bottom content padding. The lists with a floating action button (Shops, Manage Item Tags) now end with bottom content padding that clears it (FabClearance), as in MyTurnTag Creator. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y3Tt4YrVgQRxh5MCpiiric
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported from MyTurnTag Creator Android's 2.1.0 smoke-test fixes.
Change
ui/common/FabClearance.kt:FabClearance= 96.dp (SubmitFab's 64.dp + the Scaffold's 16.dp FAB margin + 16.dp clearance),fabListModifier(the lists' 24.dp margin minus the bottom) andfabClearingContentPadding.ShopListViewandItemTagListView(the two lists with a floating action button) use them, so their last row and its swipe-revealed Delete button can scroll above the + button.Test
ItemTagListViewModelTest.lastRow_scrollsAboveTheAddButton: 20 tags, scroll to the last one, and assert that its bottom is at or above the add button's top. Before the fix it failed (last row ends at 445.0.dp, the add button starts at 398.0.dp); it passes with the fix.Not ported (already in place here)
@ApplicationScopethroughSessionLifecycle, andSignInEmailAndPasswordViewModelTest.login_whenTheScreenClosesMidBootstrap_stillStoresThePermissionsAndSyncsTheLocalecovers it.password_is_requiredand Change Password showsnew_password_is_required. The two "email ... has been sent" sentences already read correctly, and there is no Tag Number help string.Local checks:
scripts/pre-push(Spotless, lint, release R8, tests) passed.🤖 Generated with Claude Code
https://claude.ai/code/session_01Y3Tt4YrVgQRxh5MCpiiric