Repository navigation
Drop the article before domain words in comments - #90
Merged
Merged
Conversation
Comments in StringResourcesTranslationTest and the values-ja header
named nativeapptemplate-agent, which the rename turns into
"<slug>-agent", and put "a"/"an" before shop and item tag, which can't
follow the first sound of the renamed word. They now say "the agent"
and "so shop must never be" / "so item tag must always be". ModelJsonTest
and the test fixtures' SHOP_DESCRIPTION ("This is shop.", as in the paid
template) drop the article too. StringResourcesTranslationTest fails on
"a" or "an" before a domain word or the product name in an English
string or plural, as in the paid template.
Closes #89
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UZJxUoubntzu7Ec7DPVfAr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #89
Summary
SHOP_DESCRIPTION = "This is a shop."→"This is shop.", as in the paid template.StringResourcesTranslationTest.english_hasNoArticleBeforeRenamedWords(same as the paid template's): fails ona/anbefore item tag(s), shop(s), shopkeeper(s) or NativeAppTemplate in any English string or plural. No English string currently violates it.[Unreleased]→ Fixed entry.Test plan
./gradlew spotlessCheck./gradlew testDebugUnitTest./gradlew lintDebug🤖 Generated with Claude Code
https://claude.ai/code/session_01UZJxUoubntzu7Ec7DPVfAr