Repository navigation
Template feedback D1: small fixes from Orange Baton - #92
Merged
Merged
Conversation
UserPreferencesSerializer fell back to parsing bytes the key did not accept as an unencrypted UserPreferences, a migration from before encryption that an app built from the template never needs. It let a plain file put on the device, or ciphertext that happens to parse once the Keystore key is gone, stand in for a signed-in shopkeeper. Such bytes are a CorruptionException now, and DataStoreModule's ReplaceFileCorruptionHandler starts over signed out. The test that pinned the fallback checks the opposite. Ported from Orange Baton (template-feedback 115, 118). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018iXcEetCio5kwB6Fhf2EJi
…erywhere The repositories and their tests called NativeAppTemplatePreferencesDataSource natPreferencesDataSource, and ItemTagRepositoryImpl mtcPreferencesDataSource, left from MyTurnTag Creator. One name now, the paid edition's, which the rename in nativeapptemplate-agent also covers. Found while building Orange Baton from the template (template-feedback 119). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018iXcEetCio5kwB6Fhf2EJi
The notices shown after a shop or the account was deleted were SnackbarDuration.Indefinite and stayed until dismissed, covering the add button. They are Short now (storedNoticeDuration); the reconfirmation of a new email address, which asks the shopkeeper to act, stays until dismissed (StoredNoticeTest). Ported from Orange Baton (template-feedback 123). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018iXcEetCio5kwB6Fhf2EJi
A Surface, Card or Dialog without colors takes its text from contentColorFor, which matches errorContainer before surface: a palette that gives errorContainer the surface's color turned every plain surface's text red in Orange Baton. Theme.kt says to give the on* colors one color too, and ContentColorTest checks that the surfaces and the background get onSurface / onBackground in both schemes. The FABs state primary / onPrimary, as SubmitFab does, instead of the default primaryContainer. Found while building Orange Baton from the template (template-feedback 120). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018iXcEetCio5kwB6Fhf2EJi
Deleting a shopkeeper deletes their organization with every shop and item tag. The dialog only asked "Are you sure?"; it says so now. Found while building Orange Baton from the template (template-feedback 13). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018iXcEetCio5kwB6Fhf2EJi
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018iXcEetCio5kwB6Fhf2EJi
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018iXcEetCio5kwB6Fhf2EJi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundle D1 of the Orange Baton template feedback, the same as NativeAppTemplate-Android #138 where the free edition has the code (no push, so 116 does not apply; 117 was already done; AGENTS.md had no Scan, 103).
nativeAppTemplatePreferencesDataSource(wasnat…andmtc…)Short(StoredNoticeTest)ContentColorTest); the FABs stateprimary/onPrimaryChecks:
spotlessCheck,:app:lintDebug,:app:minifyReleaseWithR8andtest(433 tests) pass locally; the new tests seen failing with the code under test broken; the delete-account dialog checked on the emulator against a local API.🤖 Generated with Claude Code
https://claude.ai/code/session_018iXcEetCio5kwB6Fhf2EJi