Repository navigation
Build the test target in Swift 6 and use the unused response code - #103
Merged
Merged
Conversation
The app target was already Swift 6, but NativeAppTemplateTests was still Swift 5, so data-race diagnostics in tests were only warnings and the two targets could infer different types from the same closure spelling. The tests already build without errors in Swift 6. ShopCreateViewModelTest declared httpResponseCode but passed a literal 422; it now passes the constant. Ported from MyTurnTagCreator-iOS #150 and #151. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YDK5huvuRECyVrsQEdTN9q
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NativeAppTemplateTestsmoves from Swift 5 to Swift 6 (Debug, Release), matching the app target. No test changes were neededShopCreateViewModelTestuses itshttpResponseCodeconstant (unused-variable warning)A clean build of the app and tests now has no compiler warnings. Ported from MyTurnTagCreator-iOS #150 and #151 (the Sentry and billing parts don't apply to the Free template).
Test plan
WaitUntilTest), no compiler warningsmake lintpasses🤖 Generated with Claude Code
https://claude.ai/code/session_01YDK5huvuRECyVrsQEdTN9q