Repository navigation
Show the message bar above the tab bar and label its close button - #106
Merged
Merged
Conversation
MainView overlaid the message bar on the whole screen, so with the tabs showing it covered the tab bar and blocked tab taps until closed (found on an iPhone in an app built from the same views). With the tabs showing, each tab now shows the bar in its own overlay, above the tab bar; MainView still shows it for the screens without a tab bar (MainContent.hasTabBar). The tab's accessibility label moved before that overlay, since after it it replaced the message's labels. The close button gets an explicit "Close" label (new Strings.close, Japanese 閉じる) and a 32 pt target around the 16 pt symbol. The hosting-window accessibility walk from ValidationMessageTest moved to a shared test helper (AccessibilityElements), which keeps accessibility on until the last parallel caller ends. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YDK5huvuRECyVrsQEdTN9q
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports one fix from MyTurnTag iOS, found on 2026-10-16 on a physical iPhone. The views here are the same. This template has no organizations UI, so MyTurnTag's other fixes (switch-notice rules in MessageBus, personal-organization alert, invitation adapter) don't apply here.
Message bar over the tab bar; close button
MainContent.hasTabBar)..accessibility(label:)moved before that overlay. Applied after it, it relabeled the message and its close button with the tab's name (seen on the device in MyTurnTag).Strings.close"Close" (Japanese 閉じる inLocalizable.xcstrings), and a 32 pt target (Spacing.lg) around the 16 pt symbol.Tests
SnackbarViewTestuses the hosting-window accessibility walk, moved fromValidationMessageTestinto the sharedAccessibilityElementstest helper, which keeps accessibility on until the last parallel caller ends. The 32 pt test failed with the old view. The label test passes either way, because the symbol's automatic label is "Close".MainContentTest.contentInAppTabViewHasATabBarfailed withhasTabBarbroken.Checks
make lint: 0 violations, 0 files need formattingLocalizationTest🤖 Generated with Claude Code
https://claude.ai/code/session_01YDK5huvuRECyVrsQEdTN9q