Skip to content

Fix the ungrammatical confirmation-instructions alert - #108

Merged
dadachi merged 1 commit into
mainfrom
fix/port-myturntag-2.1.0-smoke-fixes
Oct 16, 2026
Merged

dadachi merged 1 commit into
mainfrom
fix/port-myturntag-2.1.0-smoke-fixes

Conversation

@dadachi

@dadachi dadachi commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Ports the applicable part of the MyTurnTagCreator 2.1.0 smoke-test fixes.

Fixed

  • The alert after resending confirmation instructions read "An email has been sent the email containing instructions for confirming your email address." It now reads "An email with instructions for confirming your email address has been sent.", the text NativeAppTemplate-Free-Android shows (sent_confirmation_instruction, 2a3e764). The Japanese (メールアドレスの確認方法を記載したメールを送信しました。) is kept under the new key. From MyTurnTagCreator cd919c2.

Tests

LocalizationTest:

  • confirmationInstructionSentMessage checks Strings.sentConfirmationInstruction and its Japanese in the built bundle. Failed on the iPhone before the fix (both expectations), passes after.
  • noUngrammaticalEnglishKeys checks that no catalog key still has the old wording ("sent the email", "must be a 2-"). It reads the .xcstrings source, so it runs on the simulator/CI only. Its predicate returns the old key against main's catalog and nothing against this branch's.

Full suite on the iPhone: 450 tests passed. make lint passes.

Not ported

  • Reinstall Keychain cleanup (MyTurnTagCreator 71e0da6): already here since 1e3a988, with an upgrade check suited to this repo (TipKit's datastore).
  • Sentry-Dynamic (3997d48): this repo has no third-party packages.
  • "must be a 2-%lld alphanumeric characters": this wording isn't in this repo. There's no reset-password variant either; that alert has its own wording.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Y3Tt4YrVgQRxh5MCpiiric

The alert after resending confirmation instructions read "An email has
been sent the email containing instructions for confirming your email
address." It now reads "An email with instructions for confirming your
email address has been sent.", the text NativeAppTemplate-Free-Android
shows (2a3e764). The Japanese translation is kept under the new key.
Ported from MyTurnTagCreator cd919c2, which fixed the same string.

LocalizationTest checks the new English and its Japanese in the built
bundle, and that no catalog key still has the old wording.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Y3Tt4YrVgQRxh5MCpiiric
@dadachi
dadachi merged commit 9079667 into main Oct 16, 2026
2 checks passed
@dadachi
dadachi deleted the fix/port-myturntag-2.1.0-smoke-fixes branch October 16, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant