Repository navigation
Fix the ungrammatical confirmation-instructions alert - #108
Merged
Merged
Conversation
The alert after resending confirmation instructions read "An email has been sent the email containing instructions for confirming your email address." It now reads "An email with instructions for confirming your email address has been sent.", the text NativeAppTemplate-Free-Android shows (2a3e764). The Japanese translation is kept under the new key. Ported from MyTurnTagCreator cd919c2, which fixed the same string. LocalizationTest checks the new English and its Japanese in the built bundle, and that no catalog key still has the old wording. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y3Tt4YrVgQRxh5MCpiiric
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the applicable part of the MyTurnTagCreator 2.1.0 smoke-test fixes.
Fixed
sent_confirmation_instruction, 2a3e764). The Japanese (メールアドレスの確認方法を記載したメールを送信しました。) is kept under the new key. From MyTurnTagCreator cd919c2.Tests
LocalizationTest:confirmationInstructionSentMessagechecksStrings.sentConfirmationInstructionand its Japanese in the built bundle. Failed on the iPhone before the fix (both expectations), passes after.noUngrammaticalEnglishKeyschecks that no catalog key still has the old wording ("sent the email", "must be a 2-"). It reads the.xcstringssource, so it runs on the simulator/CI only. Its predicate returns the old key against main's catalog and nothing against this branch's.Full suite on the iPhone: 450 tests passed.
make lintpasses.Not ported
🤖 Generated with Claude Code
https://claude.ai/code/session_01Y3Tt4YrVgQRxh5MCpiiric