Repository navigation
Start generated apps at 1.0.0 (1); leave the template's production credentials behind - #172
Merged
Merged
Conversation
… credentials behind A generated app is a new product: iOS MARKETING_VERSION / CURRENT_PROJECT_VERSION and Android versionName / versionCode are set to 1.0.0 / 1 (Orange Baton started at the template's 3.3.3 (13) and had to be set back before its first TestFlight build). The API's config/credentials/production.yml.enc is encrypted with the template's key, which never comes along, so it is no longer copied (RAILS_SKIP_RULES). OUTPUT-CHECKLIST: 1.4 names the placeholder mark on the onboarding and sign-in screens (iOS sparkles, Android AutoAwesome); 2.5 says to make your own production credentials; new 2.7 checks the owner of the container image in deploy.yml. SUBSTRATE-CONTRACT rule 5: don't state facts about a renamed token that stop being true after the rename. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018iXcEetCio5kwB6Fhf2EJi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MARKETING_VERSION/CURRENT_PROJECT_VERSIONand AndroidversionName/versionCodeare set to 1.0.0 / 1 after the rename (src/app-version.ts). Orange Baton started at the template's 3.3.3 (13).config/credentials/production.yml.encis no longer copied (RAILS_SKIP_RULES): it is encrypted with the template's key, which never comes along.sparkles, AndroidAutoAwesome); 2.5 says how to make production credentials; new 2.7 checksimage/registry.usernamein deploy.yml.All found while building Orange Baton.
Test plan
npm run ci: 208 tests pass.config/credentialshas no production files, the pbxproj has 1.0.0 / 1 for all four configurations, build.gradle.kts hasversionCode = 1,versionName = "1.0.0".🤖 Generated with Claude Code
https://claude.ai/code/session_018iXcEetCio5kwB6Fhf2EJi