Repository navigation
Leave third-party identifiers out of the rename; dismiss the dialogs covering the Sample wait - #176
Merged
Conversation
… out of the rename A plan that renames the Completed state (Orange Baton, 2026-10-27: Completed → Passed) rewrote the RevenueCat SDK's com.revenuecat.purchases.PurchasesAreCompletedBy into an import that doesn't exist, so the Android build failed, and turned Solid Queue's completed_jobs column in db/queue_schema.rb into passed_jobs. rename.rb protects [Pp]urchasesAreCompletedBy like the GitHub links and skips the Solid Queue / Cache / Cable schemas and migrations; Layer 1 mirrors both. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…e Sample entry The paid iOS template (2026-10-25) says what notifications are for in an alert of its own before the OS prompt. It can arrive after the walk's optional taps have given up, and an alert hides the list from the accessibility tree, so wait_for_text "Sample" timed out seeing only the alert's 2 elements (Orange Baton, 2026-10-27). wait_for_text takes a dismiss list: whenever a poll doesn't find the text, it taps the first listed button it sees (OK, 許可 / Allow, 今はしない / Not Now, Cancel) and polls again. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two failures from the first
/nativeapptemplate-agent:generate-app --visual=2 --testsrun of agent 0.4.3 on the Orange Baton spec (2026-10-27), neither caused by 0.4.3 itself:Completed → Passed, andrename.rbrewrote the RevenueCat SDK'scom.revenuecat.purchases.PurchasesAreCompletedBy(Unresolved reference 'PurchasesArePassedBy') and Solid Queue'scompleted_jobscolumn indb/queue_schema.rb/db/queue_migrate/.rename.rbnow protects[Pp]urchasesAreCompletedBylike the GitHub links and skips the Solid Queue / Cache / Cable schemas and migrations; Layer 1 mirrors both (protected-references.ts,layer1.ts). A scan of all five substrates found no other third-party identifier containingCompletedorIdled.wait_for_text "Sample"timed out seeing only 2 elements.wait_for_texttakes adismisslist and taps the first listed button it sees whenever a poll doesn't find the text; the Sample wait usesOK, 許可, Allow, 今はしない, Not Now, Cancel.Test plan
npm run ci: 213 tests pass; the 4 new tests fail with the fixes stashed (rename.rb, protectedSpans + Layer 1 skip, wait_for_text dismiss, the scenario's Sample step).node dist/index.jsrun of the Orange Baton spec, paid substrates,--visual=2 --tests(13m 55s, $0.21): Android now Layer 1–3 green, Stage 2 48/48, tests green; Rails green. (The planner didn't pickCompleted → Passedthis time, so the rename protection is covered by the unit tests.)dismisscannot help: while the alert is up, the accessibility snapshot holds only the status bar (clock, Wi-Fi — the "2 elements"), with the same result from mobile-mcp's devicekit runner. The alert lives in aUIWindowof its own (NotificationReasonAlert.show), which the snapshot doesn't include. That needs a change in the template (and Orange Baton first); tracked separately. Thedismisslist stays: it covers the dialogs the snapshot does show.🤖 Generated with Claude Code