Repository navigation
fix(stage2): walk the Android device the app was installed on - #179
Merged
Merged
Conversation
With a phone and an emulator attached and NATIVEAPPTEMPLATE_ADB_SERIAL naming the emulator, the app was installed on the emulator but Stage 2 walked the phone (the first Android device mobile-mcp listed) and failed on another app's screen. Without NATIVEAPPTEMPLATE_MOBILE_ANDROID_DEVICE, selectDevice now uses NATIVEAPPTEMPLATE_ADB_SERIAL, else prefers an emulator-* like selectAdbTarget does. Found on 2026-10-29 while checking the templates' release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NATIVEAPPTEMPLATE_ADB_SERIAL=emulator-5554, the app was installed on the emulator but Stage 2 (mobile-mcp) walked the phone, the first Android device listed, and stopped on another app's screen ("the app's UI is not in English"). Without the variable the two could still disagree: the install prefers anemulator-*serial (selectAdbTarget), Stage 2 took the first Android device.selectDevicenow uses, whenNATIVEAPPTEMPLATE_MOBILE_ANDROID_DEVICEis not set,NATIVEAPPTEMPLATE_ADB_SERIAL, else anemulator-*device, like the install. README notes it.Test plan
npm run ci214/214NATIVEAPPTEMPLATE_ADB_SERIAL=emulator-5554and the Pixel 6 attached: paid VetClinic--visual=2 --testsPASS, Stage 2 walked the emulator (Android 48/48)🤖 Generated with Claude Code