Repository navigation
Render the React page for the password reset link - #12321
Merged
Merged
Conversation
PasswordsController overrode `new` to hand off to the React app, but not `edit`, so the link in the reset email fell through to Devise's stock view (there's no app/views/devise/passwords). Users got an unstyled form instead of the ResetPassword page. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UKBUsvK2TxyNpBVBi531xz
nbudin
marked this pull request as ready for review
October 30, 2026 05:11
Contributor
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Someone reported that password reset wasn't working for them. Trying it locally and on production, the "forgot password" step is fine, but the link in the reset email opens Devise's bare default form instead of our React
ResetPasswordpage: no site header, no styling, tab title "Sign In".PasswordsControlleroverridesnewto hand off to the React app, but never overrodeedit, and the app has noapp/views/devise/passwords, so Devise's stock view rendered. This adds the same one-liner override foredit. The React page reads the token from the query string itself, so nothing else is needed.Testing
Verified against the local dev server: the reset link now renders the React page. I also added controller tests for both
newandeditthat assert the app shell is served with no server-rendered form. I couldn't run them locally because my test database had leftover rows, so CI is the first real run.The bare form on production does work if you submit it (Nat tried it with a real reset), so this is a polish/regression fix rather than a hard break. I don't know for sure that it's what the reporting user hit.
Release plan and notes
🚢
🤖 Generated with Claude Code