Conversation
ghost
closed this by deleting the head repository
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL plain-text dump output can include
\restrictand\unrestrictpsql guards, which sql-parser-cst currently rejects at the first backslash.This change recognizes those two command lines only in the PostgreSQL dialect and preserves them as line-comment whitespace. CST consumers that enable
includeCommentscan round-trip the guards, while unrelated psql meta-commands remain rejected.The regression test round-trips both guards and the enclosed SQL using pg_dump's generated 63-character alphanumeric key shape.
Related to sql-formatter-org/sql-formatter#935 and sql-formatter-org/sql-formatter#966