Skip to content

chore(npm): mark the source package private - #222

Merged
CybotTM merged 1 commit into
mainfrom
chore/npm-private-source-package
Nov 9, 2026
Merged

CybotTM merged 1 commit into
mainfrom
chore/npm-private-source-package

Conversation

@CybotTM

@CybotTM CybotTM commented Nov 9, 2026

Copy link
Copy Markdown
Member

After this merges, package.json carries "private": true next to its placeholder version 0.0.0-source, so npm publish refuses to publish the placeholder. The skill-repo standard requires it (installation-methods.md); this repository was one of 17 without it, and netresearch/skill-repo-skill#454 adds a validator check for the key.

package.json carries the placeholder version 0.0.0-source. The
skill-repo standard (installation-methods.md) requires "private": true
on it, so an accidental npm publish is refused instead of shipping
the placeholder.

Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The package metadata now sets the private field to true.

Change: Other

Merge Risk: Minimal · up to b5b86

The source package is marked private to prevent publication. No merge-blocking issue is evident.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title clearly identifies the main change: marking the source npm package as private.
Description check Passed The description explains the added private flag, its purpose, and the related repository standard. It is directly related to the changeset.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d6e84d56-51bd-405d-999f-7a62906e8f76
Commits

Reviewing files that changed from the base of the PR and between 932fa93 and b5b863f.

Files selected for processing: 1

  • package.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@sonarqubecloud

sonarqubecloud Bot commented Nov 9, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions github-actions Bot added the dependencies Pull requests that update a dependency file label Nov 9, 2026
@CybotTM

CybotTM commented Nov 9, 2026

Copy link
Copy Markdown
Member Author

Self-review (the Copilot review was unavailable: the monthly quota is exhausted).

The diff is one added line, "private": true, directly after "version": "0.0.0-source", at the file's own indentation; the file still parses as JSON and nothing else changed. npm pack is unaffected by the key, so the npm-pack smoke check keeps working; only npm publish is refused. No findings.

@CybotTM
CybotTM marked this pull request as ready for review November 9, 2026 12:55
Copilot AI balanced review requested due to automatic review settings November 9, 2026 12:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

@CybotTM

CybotTM commented Nov 9, 2026

Copy link
Copy Markdown
Member Author

Self-review: b5b863f

The bot review this pull request demands is unsatisfiable (Copilot quota wall or repeated bot failures on this head). The diff on this head was reviewed by the PR author; this comment is the on-the-record attestation the merge gate reads back. It stops matching on the next push.

@CybotTM
CybotTM added this pull request to the merge queue Nov 9, 2026
Merged via the queue into main with commit 0b218db Nov 9, 2026
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants