Skip to content

fix(upload): check if we need to create a folder before creating it - #1687

Merged
susnux merged 1 commit into
mainfrom
fix/upload-test
Jul 8, 2026
Merged

fix(upload): check if we need to create a folder before creating it#1687
susnux merged 1 commit into
mainfrom
fix/upload-test

Conversation

@susnux

@susnux susnux commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

There are some cases when we need to create the folder:

  • sub folders
  • root folder if upload path was set (e.g. batchUpload('upload', ...)

So the HEAD request is more resilient.

Added tests for ensure we cover more of those cases.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

There are some cases when we need to create the folder:
- sub folders
- root folder if `upload` path was set (e.g. `batchUpload('upload',  ...)`

So the HEAD request is more resilient.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnux requested review from nfebe and skjnldsv July 6, 2026 16:33
@susnux susnux added type: bug 🐛 Something isn't working 3. to review 3️⃣ Waiting for reviews labels Jul 6, 2026
@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.15%. Comparing base (141ae5e) to head (2835d8a).

Files with missing lines Patch % Lines
lib/upload/uploader/UploadFileTree.ts 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            main    #1687       +/-   ##
==========================================
+ Coverage   0.00%   85.15%   +85.15%     
==========================================
  Files         41       44        +3     
  Lines       1014     1098       +84     
  Branches     245      274       +29     
==========================================
+ Hits           0      935      +935     
+ Misses      1014      127      -887     
- Partials       0       36       +36     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@susnux
susnux requested a review from leftybournes July 7, 2026 15:43
@susnux
susnux merged commit 3eb88af into main Jul 8, 2026
12 checks passed
@susnux
susnux deleted the fix/upload-test branch July 8, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review 3️⃣ Waiting for reviews type: bug 🐛 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants