[bulungasdeveloper]

Summary

A video and a picture with the same name are not necessarily halves of the same live photo.
Resolve the poster through the DAV live photo metadata when the video carries it, and keep the
name pairing only for videos without metadata. A picture that already belongs to another live
photo is not used as a poster by name.

This makes video poster resolution symmetric with the image path, which already uses metadata.

How to test

1. Upload a live photo pair where the still and the video have different names.
2. Open the video in the viewer.
3. The poster should be the correct still frame resolved via metadata-files-live-photo.
4. Rename the still; the poster remains correct.

Unit tests added in __tests__/component/media.spec.ts and __tests__/utils.spec.ts.

Checklist

• Code is properly formatted (eslint)
• Sign-off message is added to all commits
• Tests are included
• Documentation not required
• Backports requested where applicable: none for main

AI

• The content of this PR was partly generated using AI

[bulungasdeveloper]

Hi maintainers,
The branch has been rebased on top of main to remove the non-conventional merge commit created by Update branch.
Commit is conventional, DCO signed and AI-assisted.
The required checks are currently pending action_required due to fork protection. Could someone approve the workflow runs or review? Thanks!

[skjnldsv]

@bulungasdeveloper thanks for the PR!

@artonge what do you think of that ? You have more knowledge than me on live photos metadata :))

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.03%. Comparing base (3f6dde8) to head (c188a68).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #177   +/-   ##
=======================================
  Coverage   92.02%   92.03%           
=======================================
  Files          54       54           
  Lines        4617     4621    +4     
  Branches     1006     1009    +3     
=======================================
+ Hits         4249     4253    +4     
  Misses        343      343           
  Partials       25       25           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[susnux]

yes makes sense!

@skjnldsv only checked source which is good, not familiar with the projects tests though.

[bulungasdeveloper]

@skjnldsv could you approve the workflow runs for this PR? All checks are in action_required state because the PR comes from a fork, so they have not run yet.

The PR is already approved by @susnux. Once the workflows are approved, I can address any failures right away.

Thanks!

[artonge]

Yes, it makes sense!
Not sure if I was the one to introduce the original behaviour, but I think it should be safe to not even fallback to the filename comparison.

[bulungasdeveloper]

Thanks @susnux and @artonge for the reviews. All code and test checks are green. The only failing check is AI Policy (check-ai-trailers): it tries to add the AI assisted label, but PRs from forks get a read-only GITHUB_TOKEN, so the labels API returns 403. This is unrelated to the commit trailers. Since I only have read access to this repo, could a maintainer merge with admin override, or move the branch to the upstream repo so the workflow can use COMMAND_BOT_PAT? Thanks!

[skjnldsv]

Yes, it makes sense! Not sure if I was the one to introduce the original behaviour, but I think it should be safe to not even fallback to the filename comparison.

nope, that was me and it's a customer requirement :)