Skip to content

fix: align header with actual --body-container-margin instead of hardcoded 8px value - #181

Merged
skjnldsv merged 1 commit into
mainfrom
fix/position-adjustment
Oct 29, 2026
Merged

skjnldsv merged 1 commit into
mainfrom
fix/position-adjustment

Conversation

@ShGKme

@ShGKme ShGKme commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

I might have understood the comment above wrong, but I looks like the header is supposed to be aligned with the application container, which is --header-height + --body-container-margin from the top.

The current hardcoded 8px ignores theming, where --body-container-margin could be different or even zero.

No changes for the default theme where --body-container-margin: calc(var(--default-grid-baseline) * 2) which is 8px.

Before After
image image

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme self-assigned this Oct 29, 2026
@ShGKme ShGKme added the type: bug 🐛 Something isn't working label Oct 29, 2026
@ShGKme
ShGKme requested a review from skjnldsv as a code owner October 29, 2026 12:10
@codecov

codecov Bot commented Oct 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.98%. Comparing base (9feca65) to head (759e150).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #181   +/-   ##
=======================================
  Coverage   91.98%   91.98%           
=======================================
  Files          54       54           
  Lines        4643     4643           
  Branches     1014     1014           
=======================================
  Hits         4271     4271           
  Misses        346      346           
  Partials       26       26           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@skjnldsv skjnldsv left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's kind of over all the Nextclou dUI, not sure that really matters, but I'm also ok with this :)
I did this when I was working on the images iirc. I might have overlooked its whereabouts 🙈

@skjnldsv
skjnldsv merged commit 7e7c2d8 into main Oct 29, 2026
20 checks passed
@skjnldsv
skjnldsv deleted the fix/position-adjustment branch October 29, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug 🐛 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants