Skip to content

feat: add batch action for removing from group - #5200

Open
GVodyanov wants to merge 2 commits into
mainfrom
feat/batch-remove-group
Open

GVodyanov wants to merge 2 commits into
mainfrom
feat/batch-remove-group

Conversation

@GVodyanov

Copy link
Copy Markdown
Contributor

Fix #5191

@GVodyanov GVodyanov self-assigned this Mar 18, 2026
@GVodyanov
GVodyanov requested a review from hamza221 as a code owner March 18, 2026 21:04
@GVodyanov GVodyanov added the 3. to review Waiting for reviews label Mar 18, 2026
@codecov

codecov Bot commented Mar 18, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 12.90323% with 27 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/ContactsList.vue 6.25% 15 Missing ⚠️
src/components/ContactsList/Batch.vue 20.00% 12 Missing ⚠️

📢 Thoughts on this report? Let us know!

@hamza221 hamza221 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contacts are duplicated while removing
Image

GVodyanov and others added 2 commits November 15, 2026 23:03
Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
The selection is keyed by list index, so entries selected in one group
or address book stayed selected after switching to another one and were
shown on whichever contacts sit at the same positions there. Batch
actions then ran on the hidden entries too, which showed up as
duplicated contacts in the remove-from-group dialog.

Adds tests for the reset and for removing contacts from a group.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@GVodyanov
GVodyanov force-pushed the feat/batch-remove-group branch from 6235fc7 to 8829220 Compare November 15, 2026 22:21
@nextcloud-command nextcloud-command added the AI assisted This PR contains AI-assisted commits label Nov 15, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted This PR contains AI-assisted commits

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple selection in a group: adding a “Remove from group” action

3 participants