Skip to content

fix(contacts): use string default value for related contacts field - #5657

Open
SAY-5 wants to merge 1 commit into
nextcloud:mainfrom
SAY-5:fix/related-contacts-default-value
Open

SAY-5 wants to merge 1 commit into
nextcloud:mainfrom
SAY-5:fix/related-contacts-default-value

Conversation

@SAY-5

@SAY-5 SAY-5 commented Aug 23, 2026

Copy link
Copy Markdown

The related field's default value was the array [''], but RELATED is a single-value property in ical.js, so getFirstValue() returned an array (breaking PropertyText with this.localValue.trim is not a function) and vCard.toString() threw when saving. Using an empty string like the other single-value defaults fixes both, with a regression test alongside the existing impp one. Fixes #5625.

@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
@SAY-5
SAY-5 force-pushed the fix/related-contacts-default-value branch from ffad3ce to 5304004 Compare November 16, 2026 23:52

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Related contacts" field causes TypeError: this.localValue.trim is not a function

1 participant