Repository navigation
fix(editor): fit translated labels into the menus - #424
Merged
Merged
Conversation
Bootstrap's .label rule keeps the labels of the right-click menu on one line, so longer labels such as "Arrange Up" or "Neuer Geschwisterknoten" were cut off at the edge of the round buttons. Let them wrap, break long words, use a smaller font and centre them in the button. The theme picker's buttons have a fixed size as well, so wrap theme names such as "Kompakt runde Knoten" instead of letting them overflow. Fixes #141 Fixes #160 Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
added
bug
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #141
Fixes #160
Right-click menu (#141): the labels of the round buttons were cut off, for example "Arrange Up" showed only as "Arrange" and "Neuer Geschwisterknoten" was clipped at the edge. Bootstrap's generic
.labelrule (white-space: nowrapand padding) also applies to the hotbox labels.vendor/hotbox/hotbox.cssnow lets them wrap, breaks long words, uses 12 px instead of 16 px, and centres label and shortcut vertically in the button.Theme picker (#160): the theme buttons have a fixed size of 110 × 30 px, so longer theme names such as "Kompakt runde Knoten" or "Compact rounded nodes" ran out of the button. A rule in the iframe template now wraps them onto two lines, centred in the button. This follows the existing overrides of the editor stylesheet in
templates/viewer.php, so the minified editor CSS stays untouched.Tested: rendered the buttons in headless Firefox with the iframe's stylesheets (Bootstrap, hotbox and the editor CSS), using English, German and Spanish labels. Before the change, long labels ran past the button edge. After it, every label fits in its button. I have not yet checked it in a running Nextcloud.
A backport to
stable-0.1follows.🤖 AI (if applicable)