Repository navigation
[stable-0.1] fix(editor): accept http(s) addresses for linked images - #425
Merged
Merged
Conversation
The image dialog only accepted an address when a word character followed the scheme's colon, so every http:// and https:// address was marked invalid and the dialog could not be confirmed. Accept addresses starting with http://, https:// or data:. Fixes #178 Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de> (cherry picked from commit f95f0f6)
AndyScherzinger
added
bug
1 task done
Member
Author
|
Correction to the description: images from other servers are not blocked. The editor iframe's Content Security Policy allows images from any origin ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #421 to
stable-0.1. Fixes #178 for Nextcloud 32–35.The "Linked image" dialog rejected every
http://andhttps://address because of a broken regex in the vendored editor. It now accepts addresses that start withhttp://,https://ordata:.Images from other servers are still blocked by the editor's Content Security Policy, the same as onThis is wrong, see the correction.main.Cherry-picked without changes. I have not yet tested it in a running Nextcloud.
🤖 AI (if applicable)