Skip to content

fix(clustering): stop undefined-key warnings in SquaredDistance on ragged vectors - #1612

Merged
marcelklehr merged 1 commit into
nextcloud:mainfrom
RanaKhan77:fix/squared-distance-ragged-vectors
Nov 11, 2026
Merged

marcelklehr merged 1 commit into
nextcloud:mainfrom
RanaKhan77:fix/squared-distance-ragged-vectors

Conversation

@RanaKhan77

Copy link
Copy Markdown
Contributor

While watching the cron log on a Recognize install I hit exactly the flood described in #1611 — hundreds of Undefined array key N in .../lib/Clustering/SquaredDistance.php#50 lines per run, with different keys each time.

Cause: compute() bounds its loop on count($a) but reads $b[$i] unguarded. Any pair of vectors with different lengths (a truncated or older-format embedding row is enough) walks off the end of $b on every single comparison, which during clustering is thousands of times per cron run.

Fix: walk min(count($a), count($b)) — the dimensions both vectors share:

$count = min(count($a), count($b));

Nothing changes for well-formed equal-length vectors, and this is already what the old loop did whenever $a happened to be the shorter side, so the kernel just becomes symmetric on ragged input instead of warning. I deliberately did not switch to ?? 0.0, because padding missing dimensions with zeros would silently change the distances and therefore cluster shapes; treating ragged input as "compare over the shared prefix" keeps results identical wherever they were previously well-defined.

Test: new tests/SquaredDistanceTest.php (plain TestCase, no DB) covering the equal-length value, the ragged case from the report, symmetry between the two argument orders, and empty input. Verified the old code emits the exact reported warning with [0, 3, 7] vs [3] and the new code returns 9.0 silently.

Fixes #1611


Personal note: I build self-hosted security scanners in PHP (2MNY Website Vulnerability Scanner), so log-noise bugs like this one are a daily annoyance I'm happy to chase down. Say hi on LinkedIn if you ever compare notes on clustering false positives.

…gged vectors

compute() walked count($a) dimensions but read $b[$i] unguarded, so any
pair of vectors with different lengths (e.g. a truncated embedding row)
flooded the log with "Undefined array key N" warnings during the cron
clustering.

The loop now walks min(count($a), count($b)) — the dimensions both
vectors share — which is also what the old loop already did whenever $a
happened to be the shorter side, so the kernel is now symmetric on ragged
input and unchanged for well-formed vectors.

Adds a small unit test for the equal-length value, the ragged case from
the report, symmetry, and empty input.

Fixes nextcloud#1611

Signed-off-by: RanaKhan77 <admin@solution9.com>
@RanaKhan77
RanaKhan77 force-pushed the fix/squared-distance-ragged-vectors branch from e4177a6 to fdd25bf Compare November 10, 2026 22:35
@marcelklehr
marcelklehr merged commit a8a9bd2 into nextcloud:main Nov 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Excessive PHP warnings: Undefined array key in SquaredDistance.php during cron execution

2 participants