Repository navigation

Unified Sharing Legacy Sync - #65972

Draft

provokateurin wants to merge 23 commits into

unified-sharing-legacy-sync

Draft

Unified Sharing Legacy Sync#65972
provokateurin wants to merge 23 commits into
masterfrom
unified-sharing-legacy-sync

provokateurin commented Oct 27, 2026

Member

There are some TODOs left in the code, but I just need to get this merged, so future changes can be done in smaller PRs.

The syncing logic is not nice to understand, because it's an encoding of all the quirks and limitations the legacy sharing system has. I tried my best to leave useful comments whenever possible, but I'm happy to add more if there are questions during the review.

provokateurin added this to the Nextcloud 36 milestone

provokateurin requested review from icewind1991 and susnux

October 27, 2026 15:35

provokateurin added enhancement 2. developing labels

provokateurin self-assigned this

icewind1991 reviewed

View reviewed changes

apps/federatedfilesharing/lib/FederatedShareProvider.php Resolved

icewind1991 reviewed

View reviewed changes

apps/files/lib/Migration/Version35000Date20260910082613.php Resolved

icewind1991 reviewed

View reviewed changes

apps/files/lib/Sharing/SharesUpdatedListener.php Resolved

icewind1991 reviewed

View reviewed changes

apps/files/lib/Sharing/SourceNodeTargetManager.php Resolved

icewind1991 reviewed

View reviewed changes

apps/files/lib/Sharing/SharesUpdatedListener.php Resolved

icewind1991 reviewed

View reviewed changes

lib/unstable/Sharing/Recipient/IShareRecipientType.php Resolved

icewind1991 reviewed

View reviewed changes

lib/private/Share20/Manager.php Resolved

icewind1991 reviewed

View reviewed changes

apps/sharing/lib/Migration/Version1000Date20260903133238.php Resolved

icewind1991 reviewed

View reviewed changes

apps/sharing/lib/Migration/Version2000Date20261101154320.php Resolved

icewind1991 reviewed

View reviewed changes

lib/unstable/Sharing/Share.php Resolved

icewind1991 reviewed

View reviewed changes

lib/private/Sharing/SharingLegacySync.php Resolved

icewind1991 reviewed

View reviewed changes

lib/private/Sharing/SharingLegacySync.php Resolved

icewind1991 reviewed

View reviewed changes

lib/private/Sharing/SharingLegacySync.php Resolved

icewind1991 reviewed

View reviewed changes

lib/private/Sharing/SharingLegacySync.php Resolved

icewind1991 reviewed

View reviewed changes

lib/private/Sharing/SharingLegacySync.php Resolved

provokateurin force-pushed the unified-sharing-legacy-sync branch from 2279e86 to 6fad6c3 Compare

October 28, 2026 14:06

provokateurin commented

View reviewed changes

lib/unstable/Sharing/Property/APasswordSharePropertyType.php Resolved

provokateurin force-pushed the unified-sharing-legacy-sync branch 2 times, most recently from b564558 to 073afcd Compare

November 3, 2026 11:16

susnux reviewed

View reviewed changes

apps/files/lib/Migration/Version35000Date20260910082613.php Resolved

susnux reviewed

View reviewed changes

apps/federatedfilesharing/lib/FederatedShareProvider.php Resolved

provokateurin force-pushed the unified-sharing-legacy-sync branch from 073afcd to 2e42500 Compare

November 4, 2026 12:06

provokateurin mentioned this pull request

test: Reset the correct mount provider collection instance and add back the files_sharing mount provider #66502

Merged

provokateurin commented Nov 10, 2026

Member Author

Needs #66502

provokateurin force-pushed the unified-sharing-legacy-sync branch 2 times, most recently from 21c5896 to 34454ce Compare

November 11, 2026 10:25


          fix(Sharing): Fix event listeners with ghosts

b8ab84f

Signed-off-by: provokateurin <kate@provokateurin.de>

provokateurin mentioned this pull request

fix(Sharing): Fix event listeners with ghosts #66524

Merged

provokateurin added 9 commits

November 11, 2026 14:49


          refactor(Sharing): Tighten more types

40869c5

Signed-off-by: provokateurin <kate@provokateurin.de>


          refactor(files_sharing): Set expiration date time to 23:59:59 only in…

ac7453f

… the controller

Signed-off-by: provokateurin <kate@provokateurin.de>


          feat(IShare): Add getProviderId()

8582ba8

Signed-off-by: provokateurin <kate@provokateurin.de>


          feat(Share20): Dispatch ShareUpdatedEvent and ShareRestoredEvent

c3ca67b

Signed-off-by: provokateurin <kate@provokateurin.de>


          feat(OCP\Share\Events): Add setters for the share property

Signed-off-by: provokateurin <kate@provokateurin.de>


          feat(SharingManager): Dispatch SharesUpdatedEvent and SharesDeletedEvent

2f4f3b8

Signed-off-by: provokateurin <kate@provokateurin.de>


          feat(DefaultShareProvider): Allow fetching shares of TYPE_USERGROUP

891a8be

Signed-off-by: provokateurin <kate@provokateurin.de>


          feat(ITeamManager): Allow calling getMembersOfTeam() without a user

b88c5b0

Signed-off-by: provokateurin <kate@provokateurin.de>


          feat(IShareRecipientType): Add getUsers()

ad52e64

Signed-off-by: provokateurin <kate@provokateurin.de>

provokateurin commented Nov 11, 2026

Member Author

Needs #66524

provokateurin added 13 commits

November 11, 2026 14:53


          feat(Sharing): Add node source target management

4366fdb

Signed-off-by: provokateurin <kate@provokateurin.de>


          refactor(ISharePropertyTypeModifyValue): Modify values on format inst…

07892c3

…ead of load

Signed-off-by: provokateurin <kate@provokateurin.de>


          refactor(ISharePropertyTypeModifyValue): Modify values on save in the…

d86be3b

… manager instead of the backend

Signed-off-by: provokateurin <kate@provokateurin.de>


          feat(Share): Add getCreatedAt() method

f070496

Signed-off-by: provokateurin <kate@provokateurin.de>


          feat(ISharingBackend): Add getUserStatuses() method

e52ee50

Signed-off-by: provokateurin <kate@provokateurin.de>


          feat(files): Add NodeNicknameSharePropertyType

90cb1d0

Signed-off-by: provokateurin <kate@provokateurin.de>


          fix(ShareByMailProvider): Set share status from DB

930d76e

Signed-off-by: provokateurin <kate@provokateurin.de>


          fix(Share20): Fix setting target before and after the share is create…

d2f4217

…d in the provider

Signed-off-by: provokateurin <kate@provokateurin.de>


          fix(FederatedShareProvider): Use existing share time and token if ava…

ffdcc59

…ilable

Signed-off-by: provokateurin <kate@provokateurin.de>


          refactor(Share): Allow checking effective enabled permissions for exp…

2a5e238

…licit recipients

Signed-off-by: provokateurin <kate@provokateurin.de>


          feat(Sharing): Implement bi-directional syncing with legacy sharing

f2bf3ec

Signed-off-by: provokateurin <kate@provokateurin.de>


          test(integration): Enable Unified Sharing legacy sync validation

54ed407

Signed-off-by: provokateurin <kate@provokateurin.de>


          chore(Sharing): Remove outdated TODOs

de07613

provokateurin force-pushed the unified-sharing-legacy-sync branch from 34454ce to de07613 Compare

November 11, 2026 14:07

This branch has not been deployed

No deployments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing enhancement