Skip to content

[stable34] chore(deps): bump @nextcloud/dialogs from 7.5.0 to 7.6.0 - #66092

Merged
susnux merged 3 commits into
stable34from
dependabot/npm_and_yarn/build/frontend-legacy/stable34/nextcloud/dialogs-7.6.0
Nov 10, 2026
Merged

susnux merged 3 commits into
stable34from
dependabot/npm_and_yarn/build/frontend-legacy/stable34/nextcloud/dialogs-7.6.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Bumps @nextcloud/dialogs from 7.5.0 to 7.6.0.

Release notes

Sourced from @​nextcloud/dialogs's releases.

v7.6.0

v7.6.0

Notes

The reworked toast notifications from v7.5.0 were considered a breaking change and are moved to v8. This version restores the previous toastify-js based toasts and removes the toast timeout configuration.

If your app only needs toasts, you can import them from the @nextcloud/dialogs/toast entry point instead. (Note: Webpack issue - bundler might include other components source, e.g. the FilePicker, in the app)

import { showError } from '@nextcloud/dialogs/toast'

Added

Fixed

  • fix(dav): Prevent race condition in useDAVFiles #2511 (DerDreschner)
  • fix(filepicker): allow select other files if already selected #2617 (susnux)
  • fix: properly name languages matching server #2620 (susnux)
  • fix(ConflictPicker): scoped styles are needed for :deep to work #2649 (rotdrop)
  • fix(build): restore @nextcloud/dialogs/style.css output #2672 (Antreesy)

Changed

  • revert: accessible toast and toast timeout configuration #2712 (Antreesy)
  • perf(FilePicker): replace NcActionInput with NcPopover and NcTextField #2690 (Antreesy)
  • Updated translations
  • Updated development dependencies
Changelog

Sourced from @​nextcloud/dialogs's changelog.

v7.6.0

Notes

The reworked toast notifications from v7.5.0 were considered a breaking change and are moved to v8. This version restores the previous toastify-js based toasts and removes the toast timeout configuration.

If your app only needs toasts, you can import them from the @nextcloud/dialogs/toast entry point instead. (Note: Webpack issue - bundler might include other components source, e.g. the FilePicker, in the app)

import { showError } from '@nextcloud/dialogs/toast'

Added

Fixed

  • fix(dav): Prevent race condition in useDAVFiles #2511 (DerDreschner)
  • fix(filepicker): allow select other files if already selected #2617 (susnux)
  • fix: properly name languages matching server #2620 (susnux)
  • fix(ConflictPicker): scoped styles are needed for :deep to work #2649 (rotdrop)
  • fix(build): restore @nextcloud/dialogs/style.css output #2672 (Antreesy)

Changed

  • revert: accessible toast and toast timeout configuration #2712 (Antreesy)
  • perf(FilePicker): replace NcActionInput with NcPopover and NcTextField #2690 (Antreesy)
  • Updated translations
  • Updated development dependencies
Commits
  • d8f29e1 Merge pull request #2713 from nextcloud-libraries/chore/release-7.6.0-stable7
  • 9b35e29 Merge pull request #2712 from nextcloud-libraries/revert/stable7-toast-rework
  • 96838e0 chore: release v7.6.0
  • 740c304 revert: feat: accessible toast and drop toastify
  • 12c4442 revert: feat: toast timeout configuration
  • dd5aa80 revert: fix(toast): position when closed
  • 5a69a39 revert: feat(toast): add support for RTL and custom offset
  • f248ea3 Merge pull request #2690 from nextcloud-libraries/perf/file-picker-new-folder...
  • bc258ae Merge pull request #2708 from nextcloud-libraries/translations_441be4f7621043...
  • c9d1303 Translate l10n/messages.pot in da
  • Additional commits viewable in compare view

@dependabot
dependabot Bot requested review from a team as code owners October 31, 2026 04:00
@dependabot
dependabot Bot requested review from kristian-zendato, pringelmann and skjnldsv and removed request for a team October 31, 2026 04:01
@github-actions github-actions Bot changed the title chore(deps): bump @nextcloud/dialogs from 7.5.0 to 7.6.0 in /build/frontend-legacy [stable34] chore(deps): bump @nextcloud/dialogs from 7.5.0 to 7.6.0 in /build/frontend-legacy Oct 31, 2026
@AndyScherzinger

Copy link
Copy Markdown
Member

@dependabot rebase

@dependabot dependabot Bot changed the title [stable34] chore(deps): bump @nextcloud/dialogs from 7.5.0 to 7.6.0 in /build/frontend-legacy chore(deps): bump @nextcloud/dialogs from 7.5.0 to 7.6.0 in /build/frontend-legacy Oct 31, 2026
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/build/frontend-legacy/stable34/nextcloud/dialogs-7.6.0 branch from 657d591 to f99498b Compare October 31, 2026 12:04
@github-actions github-actions Bot changed the title chore(deps): bump @nextcloud/dialogs from 7.5.0 to 7.6.0 in /build/frontend-legacy [stable34] chore(deps): bump @nextcloud/dialogs from 7.5.0 to 7.6.0 in /build/frontend-legacy Oct 31, 2026
@AndyScherzinger

Copy link
Copy Markdown
Member

/compile

@AndyScherzinger AndyScherzinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes: @nextcloud/dialogs 7.6.0 deliberately reverts the toast rework from 7.5.0 (nextcloud-libraries/nextcloud-dialogs#2712, "considered a breaking change and moved to v8"). The red Playwright test is the symptom, not the problem.

Why CI fails: tests/playwright/support/utils/toast.ts locates toasts by [role="alert"], [role="status"], which the 7.5.0 toasts set. 7.6.0 goes back to toastify-js, which only sets aria-live and no role, so e.g. files: Drag and Drop › ignores dropped folders (legacy File API) never finds its toast.

What merging would regress:

  • The accessible toasts (role="alert"/role="status") adopted with 7.5.0 are lost again.
  • The toast functions return a Toastify Toast again instead of 7.5.0's ToastHandle.

Adjusting the test helper to also match .toastify would turn this green and ship the regressions above, so please do not merge this as is. The accessible toasts and the timeout configuration are back in @nextcloud/dialogs 8.0.0, which is the way forward on master; stable branches should stay on 7.5.0.

dependabot Bot and others added 2 commits November 10, 2026 13:04
Bumps [@nextcloud/dialogs](https://github.com/nextcloud-libraries/nextcloud-dialogs) from 7.5.0 to 7.6.0.
- [Release notes](https://github.com/nextcloud-libraries/nextcloud-dialogs/releases)
- [Changelog](https://github.com/nextcloud-libraries/nextcloud-dialogs/blob/main/CHANGELOG.md)
- [Commits](nextcloud-libraries/nextcloud-dialogs@v7.5.0...v7.6.0)

---
updated-dependencies:
- dependency-name: "@nextcloud/dialogs"
  dependency-version: 7.6.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux
susnux force-pushed the dependabot/npm_and_yarn/build/frontend-legacy/stable34/nextcloud/dialogs-7.6.0 branch from 1e1a8b2 to d194611 Compare November 10, 2026 12:09
@nextcloud/dialogs 7.6.0 reverts the reworked toasts of 7.5.0 and is back
to the `toastify-js` based ones. Those only set `aria-live` but no
`alert` / `status` role, so the role based toast locators never matched:
visibility checks failed and the `toHaveCount(0)` checks passed without
looking at a toast.

Add a `getToast()` helper matching the `.toastify` element by its text
and use it for all toast assertions.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

@susnux susnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed to un-break breaking changes

@susnux
susnux disabled auto-merge November 10, 2026 15:08
@susnux
susnux merged commit 8d57bb3 into stable34 Nov 10, 2026
126 of 129 checks passed
@susnux
susnux deleted the dependabot/npm_and_yarn/build/frontend-legacy/stable34/nextcloud/dialogs-7.6.0 branch November 10, 2026 15:08
@susnux susnux changed the title [stable34] chore(deps): bump @nextcloud/dialogs from 7.5.0 to 7.6.0 in /build/frontend-legacy [stable34] chore(deps): bump @nextcloud/dialogs from 7.5.0 to 7.6.0 Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants