Repository navigation
test(personal-kits): give detector cost scans a timeout above the 5 s default - #131
Merged
Merged
Conversation
… default The linear-time cases scan 1 MiB several times and take seconds; under a parallel full-suite run they exceeded vitest's 5 s default, contradicting the file's promise of no wall-clock bound. The ratio check is unchanged. Closes #129 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016RCDbVS52poV8kxgnXrrBY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #129 (found while verifying #128).
Change
apps/web/tests/personal-kits/proposal-detector-cost.test.ts: the linear-time cases and the end-of-run case now have a 120 s timeout. The 1 MiB scans take seconds (the "chained assignments" case took about 3.5 s alone), and during a parallel full-suite run they went over vitest's 5 s default. That contradicts the file header's "No wall-clock bound". The ratio assertion (MAX_RATIO,FLOOR_MS,RUNS) is unchanged.Verification
npx vitest runon a 4-core machine failed withscans chained assignments in linear time: Test timed out in 5000ms.pnpm typecheck: clean.Generated by Claude Code