Repository navigation
Add official agent-qa testing skills - #137
pranshuchittora wants to merge 3 commits into
Conversation
clark-cant
left a comment
There was a problem hiding this comment.
Summary: Adds four curated catalog entries for vostride's agent-qa skill family (authoring, debug/fix, result triage, knowledge) to scripts/build-seed-data.mjs and regenerates scripts/seed-data.json (+128/−0 across 2 files). No product code is touched.
Risk level: Low
Mandatory gates
- Duplicate / prior implementation: clear — no existing
vostride/*oragent-qaslug among the 5,113 records, and no other PR or issue covers this family. - Project standards: docs found —
scripts/README.mddocuments the curated-add workflow, the skill schema, the category enum (testingis valid) and thenpx skills add …install-command convention used by every existing record. - Strategic necessity: clear value — adds breadth to the
testingcategory (1,113 of 5,113 records), with vendor affiliation disclosed in the description.
Verification performed
- All four
source_urldirectories exist onvostride/agent-qa(skills/agent-qa-{authoring,debug-fix,result-triage,knowledge}), each with aSKILL.mdwhosenamematches the--skillselector. LICENSE.mdin that repo is the Functional Source License 1.1, ALv2 Future License, matching the disclosed "FSL-1.1-ALv2". GitHub reports the repo licence as "Other"/NOASSERTION only because FSL is non-standard, so the claim in the entry is accurate — and the licence file does ship, which matters for #145.build-seed-data.mjsskips slugs that already exist, so a re-run adds 0 rows; theseed-data.jsondiff is consistent with a real regeneration.github_stars: 893is in line with the repo (908 at review time).
Findings
- Critical: none
- Important: none
- Suggestion: the same promotional paragraph ("agent-qa by vostride runs natural-language QA … self-improvement across runs.") is repeated verbatim in all four
contentfields.contentis what search results and detail pages render, so keeping it once (or trimming it to a clause per entry) would reduce noise. - Suggestion:
github_starsis a 2026-10-25 snapshot; worth refreshing before merge or noting the capture date, since curated rows are not refreshed by the store.
Not a code issue, but blocking merge: no workflow ran on this PR (statusCheckRollup is empty, mergeStateStatus is UNSTABLE), which is the usual first-time-contributor workflow-approval gate. A maintainer needs to approve the runs before this can go green.
Verdict: Comment — minor suggestions only, safe to merge once CI is approved.
Posted by /github-maintain (ck:review-pr) at 2026-10-29T16:06:36Z
|
Addressed both suggestions in fe9770a: the shared product overview now appears only in the authoring entry, and all four star counts use the 2026-10-31 snapshot (912), with the capture date recorded beside the curated entries. Native generation is idempotent; exactly the four agent-qa records change and the other 5,113 entries are unchanged. Syntax and whitespace checks pass. |
clark-cant
left a comment
There was a problem hiding this comment.
Re-review at fe9770a (second commit, +15/-14 over the same two files). Both suggestions from the 2026-10-29 review are addressed, and nothing new was introduced.
What changed and what I verified
- Repeated product overview removed. The "agent-qa by vostride runs natural-language QA ..." paragraph now appears in exactly one
contentfield (vostride-agent-qa-authoring); the debug-fix, result-triage and knowledge entries each keep only their own summary plus the requirements/licence paragraph. - Star snapshot refreshed and dated. All four entries are
github_stars: 912, matchingvostride/agent-qaat review time (912 stargazers), with a comment above the first entry recording the 2026-10-31 capture date. - Regeneration is genuine, not a hand edit.
scripts/seed-data.jsonat the head parses cleanly and holds 5,117 records with 4vostride-agent-qa-*entries,category: testing, zero duplicate slugs, and only those four records touched — the other 5,113 are unchanged, exactly as the PR body claims (+65/-0 inbuild-seed-data.mjs, +64/-0 net inseed-data.json). - Source provenance still holds. The four
source_urlskill directories exist onvostride/agent-qa, and the repo licence remains FSL-1.1-ALv2, which is what the entries disclose.
Remaining (suggestion, not blocking)
- The capture date lives only as a code comment in
build-seed-data.mjs.seed-data.json— the artifact the store actually renders — carries no date, so a future reader of the catalog cannot tell how old the 912 figure is. If the freshness matters, put the date in the entrycontentor accept the source comment as the record.
Merge state (unchanged, not a code problem)
statusCheckRollupis still empty and the checks API reportsstate: pending,total_count: 0forfe9770a— no workflow has ever executed on this branch. This is the first-time-contributor approval gate, so no gate can turn green until a maintainer approves the workflow runs.reviewDecisionis empty;mergeStateStatusisUNSTABLE; no approving review exists.
Verdict: Comment — both prior suggestions resolved, no critical or important findings. Safe to merge once a maintainer approves the workflow runs.
Posted by /ck:review-pr at 2026-10-31T10:05:00Z
Signed-off-by: vostride <pranshuchittora@users.noreply.github.com>
clark-cant
left a comment
There was a problem hiding this comment.
Re-review at d688022 (third commit: +4/-4 in scripts/build-seed-data.mjs, +4/-4 in scripts/seed-data.json). The one remaining suggestion is resolved and nothing else moved.
What changed and what I verified
- The date is now in the rendered content. All four
agent-qacontentstrings end their requirements paragraph withGitHub stars checked on 2026-10-31.— exactly 4 occurrences in the generator and 4 in the artifact, and no other text differs. - Parity with
mainis exact. Parsedscripts/seed-data.jsonat the head: 5,117 records versus 5,113 onmain— the 4vostride-agent-qa-*records added, 0 modified, 0 removed. All four remaincategory: testingwithgithub_stars: 912. - This is a real regeneration, not a hand edit. Each of the four JSON
contentvalues appears as an exact JSON literal inbuild-seed-data.mjsat the head, so the generator and the artifact agree byte for byte. - Nothing else in the PR moved: same two files, same four install commands, same FSL-1.1-ALv2 disclosure,
git diff --checkclean as claimed.
Nit (cosmetic, not worth a commit)
The new sentence carries the date but not the number — the count lives in the separate github_stars: 912 field, so "GitHub stars checked on 2026-10-31." reads slightly oddly on its own. "912 GitHub stars as of 2026-10-31" would be self-contained. No action needed.
Merge state (unchanged, and not something the author can fix)
check-runsford688022returnstotal_count: 0— no workflow has ever executed on this branch. That is the first-time-contributor workflow-approval gate.reviewDecisionis empty;mergeStateStatusisUNSTABLE; no approving review exists.
Verdict: Comment — the last suggestion is addressed, no critical or important findings, and no further re-review is needed from this side. Safe to merge once a maintainer approves the workflow runs.
Posted by /ck:review-pr at 2026-10-31T16:05:54Z
Add the four existing official agent-qa skills to the curated testing catalog: authoring, debug/fix, result triage, and knowledge inspection. agent-qa by vostride brings natural-language QA for web, Android, and iOS together with advanced memidex memory and self-improvement.
This follows the manual curation workflow in
scripts/README.md: add records tobuild-seed-data.mjs, then regenerateseed-data.json. All 5,113 existing records remain unchanged; the catalog grows to 5,117. Each entry links its official skill directory and includes an individual install command. New install/rating counters are zero; 912 GitHub stars were observed on 2026-10-31; the source records now include the capture date. Skills are not independently versioned, so the optional version field is omitted.The entries disclose Node.js 24+, runtime/provider setup, possible provider/device costs, and the FSL-1.1-ALv2 source license. These are catalog summaries of the existing skills, not changes to the skills or product. I am affiliated with vostride.
Original validation (2026-10-25) on Node.js 22.22.2 / pnpm 10.22.0:
git diff --checkpasses.assert-seed-identity.mjsreports the same 48 duplicate source identities and 4 noncanonical slugs on unchanged upstream95b51dfand this branch; the four new entries introduce no additional errors.pnpm lintand rootpnpm tsc --noEmitcommands are unavailable in the current root package. The actual workspacepnpm typechecksucceeds.Validation covers this catalog contribution. It does not claim a live agent-qa application run, Claude Code session, or deployment to SkillX.
Source: https://github.com/vostride/agent-qa/tree/main/skills
Review update (2026-10-31): retained the shared product overview only in the authoring entry and refreshed the dated star snapshot. JavaScript syntax, native generation, idempotency, unchanged-record comparison, and whitespace checks pass; all 5,113 unrelated entries are unchanged.
Follow-up to the 2026-10-31 re-review: the star snapshot date now appears in the rendered content of all four agent-qa entries. Regenerated seed-data.json using the native builder; all 5,113 other records and every non-content field are unchanged. git diff --check passes. The first-time-contributor workflow approval remains a maintainer action.