Remove duplicate lines in sentieon/coveragemetrics - #12833
Merged
Conversation
SPPearce
reviewed
Aug 27, 2026
SPPearce
left a comment
SPPearce
left a comment
Contributor
There was a problem hiding this comment.
Can you use sanitizeOutput instead please. That will removed the numbered lines and simplify the output somewhat.
Comment on lines
+96
to
+101
| { assert snapshot(process.out.per_locus).match() }, | ||
| { assert process.out.sample_summary == [] }, | ||
| { assert process.out.statistics == [] }, | ||
| { assert process.out.coverage_counts == [] }, | ||
| { assert process.out.coverage_proportions == [] }, | ||
| { assert process.out.interval_summary == [] } |
Contributor
There was a problem hiding this comment.
Suggested change
| { assert snapshot(process.out.per_locus).match() }, | |
| { assert process.out.sample_summary == [] }, | |
| { assert process.out.statistics == [] }, | |
| { assert process.out.coverage_counts == [] }, | |
| { assert process.out.coverage_proportions == [] }, | |
| { assert process.out.interval_summary == [] } | |
| { assert snapshot(sanitizeOutput(process.out)).match() } |
Contributor
Author
There was a problem hiding this comment.
I didn't know about the sanitizeOutput function. Thanks @SPPearce
4 tasks
SPPearce
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes duplicated lines from the
stubblock, and updates the test in order to remove empty lines in the produced test snapshot.nf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile conda