Fix parse_rank(), rank_name() - #1205
Open
jacksonthall22 wants to merge 1 commit into
Open
Conversation
jacksonthall22
added a commit
to jacksonthall22/chess.ts
that referenced
this pull request
Aug 19, 2026
Approved divergence from pinned python-chess 1ce4d3f8. Mirrors the proposed upstream correction in niklasf/python-chess#1205 (81f9000).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I apparently committed this bug 11 months ago in #1163. Codex found it while helping me build
chess.ts, a transpilation ofpython-chessto typescript. I basically instruct it to go commit by commit and reproduce the diffs as faithfully as possible, notwithstanding syntax and a few language-specific patterns for which I document explicit instructions/conventions for how to transpile - but it's not supposed to make any decisions or changes, even if the python is wrong, unoptimized, etc. It initially, correctly, coded the bug into the typescript and left me a TODO to fix when it's patched inpython-chess. Funny that otherwise I would have never noticed this 😛