Repository navigation
Fix the flaky admin user search scenario - #2
Merged
Merged
Conversation
The scenario "Search users by username and status" sometimes saw all 28 users instead of only Admin (main run 39758065455). The filters were typed while the System Users page was still loading its table, and the page then re-rendered and cleared the username; Search ran unfiltered. - isDisplayed() now also waits for the loader and the record counter, so the filters are only typed into a fully loaded page. - filterByUsername() waits until the field really holds the text. - search() waits until the old table is replaced or the counter changes, so the assertion never reads the rows from before the search. - The assertion message now shows the filter value, the counter and all usernames, so a future failure explains itself. Locally: admin scenarios 8/8 and the full suite 4/4 in a row (one earlier batch failed while the public demo site was unreachable). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainfailed after a README-only merge (run 39758065455): Search users by username and status listed all 28 users instead of only Admin.Cause: the filters were typed while the System Users page was still loading its table; the page re-rendered, the username was lost, and Search ran without it. (The assertion's new diagnostic showed counter "(28) Records Found" with the full user list.)
Fix (page object only, scenario unchanged):
isDisplayed()also waits for the loader and the record counter.filterByUsername()waits until the field holds the typed text.search()waits until the old table is replaced or the counter changes.Local evidence: admin scenarios 8/8 and full suite 4/4 in a row against the public OrangeHRM demo.
🤖 Generated with Claude Code