Repository navigation
feat(import): split source data worksheets into tables - #135
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
XLSX import, in the desktop and through
data.import, reads journal Source Data worksheets as clean tables:Figure 3 b.--,NaN,N/Aandn.d., and other text among values, as missing in numeric columns, and ignores notes below the values.data.importacceptsregions(sheet, A1range,header_rows,name,split_segments) to import explicit ranges, and reports each table'srange. A region or table that fails fails on its own.Worksheets with one row of distinct text headers over one block of plain data import as before.
Validation
cargo pr-checknpm run buildindocs/plotium-cli tool run.