Skip to content

feat(nmr): support persistent manual 3D peak editing - #166

Merged
nmrtist merged 1 commit into
mainfrom
feature/nmr-3d-peaks
Nov 4, 2026
Merged

nmrtist merged 1 commit into
mainfrom
feature/nmr-3d-peaks

Conversation

@nmrtist

@nmrtist nmrtist commented Nov 4, 2026

Copy link
Copy Markdown
Owner

Summary

Record and revisit manual peaks directly in 3D spectra, with stable IDs and acquisition-axis coordinates across slices and project reloads.

  • Add linked peak picking, dragging, deletion and notes, with one undo step per edit and shared desktop, CLI and MCP operations.
  • Preserve peak positions through phase changes, refresh signed sampled heights, and export JSON with axis identities and acquisition/processing provenance.
  • Give 3D phase settings a separate entry that ends peak picking; retain standalone 1D/2D phase settings and interactive tools. Update English and Chinese documentation.

Validation

  • cargo pr-check — passed, including numerical, UI interaction and CLI/MCP regression tests.
  • npm run build in docs/ — passed.
  • Headless UI acceptance on three local 3D NMR datasets — passed: peak editing, table navigation in all three orientations, undo/redo, project reload and JSON export.

UI display logic

  • New or changed actions go through the command catalog (CommandId +
    describe) and are searchable in the command palette.
  • Hiding happens only at Ribbon-group level (dataset kind or width
    budget); transient states disable with a disabled_reason that says how
    to unblock.
  • No layout changes from background events; panels are never auto-closed.
  • New panels or empty regions show an empty state with a next step.
  • Docs updated in docs/ (English and zh-CN) for user-visible behavior.

@nmrtist
nmrtist merged commit 328a93c into main Nov 4, 2026
11 checks passed
@nmrtist
nmrtist deleted the feature/nmr-3d-peaks branch November 4, 2026 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant